Bug 198799

Summary: [iOS] Adjust tests platform/ipad/fast/forms/{select-form-run-twice, unfocus-inside-fixed-hittest}.html following r243808
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, megan_gardner, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar, PlatformOnly
Version: WebKit Local Build   
Hardware: iPhone / iPad   
OS: iOS 12   
Attachments:
Description Flags
Patch
none
To land none

Daniel Bates
Reported 2019-06-12 13:06:23 PDT
Following r243808 (bug #196272) we no longer defocus a <select> on iPad when its popover is dismissed as a result of picking a value for it. This is to make behavior of <select> on iPad like the Mac. We need to update the tests platform/ipad/fast/forms/{select-form-run-twice, unfocus-inside-fixed-hittest}.html to not expect the defocusing of the <select>, which they observe by way of registering for a uiController.didEndFormControlInteractionCallback callback.
Attachments
Patch (2.97 KB, patch)
2019-06-12 13:09 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
To land (2.84 KB, patch)
2019-06-12 16:07 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2019-06-12 13:06:48 PDT
<rdar://problem/50181023>
Daniel Bates
Comment 2 2019-06-12 13:09:16 PDT
Created attachment 371982 [details] Patch
Brent Fulgham
Comment 3 2019-06-12 13:38:37 PDT
Comment on attachment 371982 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371982&action=review > LayoutTests/platform/ipad/fast/forms/select-form-run-twice.html:56 > + uiController.uiScriptComplete() Nit: Semicolon at end of statement.
Daniel Bates
Comment 4 2019-06-12 16:06:05 PDT
(In reply to Brent Fulgham from comment #3) > Comment on attachment 371982 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=371982&action=review > > > LayoutTests/platform/ipad/fast/forms/select-form-run-twice.html:56 > > + uiController.uiScriptComplete() > > Nit: Semicolon at end of statement. It's JavaScript. Automatic semicolon insertion applies 😀 <-- seriously, this is language feature. I'll add the semicolon just because I like the aesthetics.
Daniel Bates
Comment 5 2019-06-12 16:07:05 PDT
Created attachment 371996 [details] To land
Daniel Bates
Comment 6 2019-06-12 16:08:02 PDT
Committed r246386: <https://trac.webkit.org/changeset/246386>
Note You need to log in before you can comment on or make changes to this bug.