Bug 198681

Summary: Extend quirks to emulate bold/italic/underline in hidden editable areas
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Megan Gardner
Reported 2019-06-07 14:59:06 PDT
Extend quirks to emulate bold/italic/underline in hidden editable areas
Attachments
Patch (12.27 KB, patch)
2019-06-07 15:03 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (12.22 KB, patch)
2019-06-07 15:51 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch for landing (12.22 KB, patch)
2019-06-07 16:54 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2019-06-07 15:03:15 PDT
Created attachment 371614 [details] Patch
Wenson Hsieh
Comment 2 2019-06-07 15:15:20 PDT
Comment on attachment 371614 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371614&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3125 > +static bool shouldSynthezieKeyEvents(WKContentView *contentView) > +{ > + if (contentView.focusedElementInformation.shouldSynthesizeKeyEventsForEditing && contentView.hasHiddenContentEditable) > + return true; > + return false; > +} It seems like this could just be a method like so: - (BOOL)shouldSynthesizeKeyEvents { return _focusedElementInformation.shouldSynthesizeKeyEventsForEditing && self.hasHiddenContentEditable; } > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3145 > + if (shouldSynthezieKeyEvents(self)) "Synthezie"
Megan Gardner
Comment 3 2019-06-07 15:51:36 PDT
Created attachment 371619 [details] Patch
Megan Gardner
Comment 4 2019-06-07 16:54:51 PDT
Created attachment 371632 [details] Patch for landing
Megan Gardner
Comment 5 2019-06-07 16:55:32 PDT
<rdar://problem/46430520>
WebKit Commit Bot
Comment 6 2019-06-07 17:48:00 PDT
The commit-queue encountered the following flaky tests while processing attachment 371632 [details]: resize-observer/element-leak.html bug 198666 The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2019-06-07 17:48:48 PDT
Comment on attachment 371632 [details] Patch for landing Clearing flags on attachment: 371632 Committed r246226: <https://trac.webkit.org/changeset/246226>
WebKit Commit Bot
Comment 8 2019-06-07 17:48:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.