Bug 198653

Summary: Disable wasm signaling memories on iOS.
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: JavaScriptCoreAssignee: Keith Miller <keith_miller>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: ews-watchlist, mark.lam, msaboff, saam, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-watchlist: commit-queue-
Archive of layout-test-results from ews211 for win-future none

Keith Miller
Reported 2019-06-07 02:47:32 PDT
Disable wasm signaling memories on iOS.
Attachments
Patch (2.18 KB, patch)
2019-06-07 02:49 PDT, Keith Miller 		ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews211 for win-future (13.85 MB, application/zip)
2019-06-07 07:21 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2019-06-07 02:49:05 PDT
Created attachment 371577 [details] Patch
EWS Watchlist
Comment 2 2019-06-07 02:51:59 PDT
Attachment 371577 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/Options.h:496: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/Options.h:495: One space before end of line comments [whitespace/comments] [5] ERROR: Source/JavaScriptCore/runtime/Options.h:495: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
EWS Watchlist
Comment 3 2019-06-07 07:21:08 PDT
Comment on attachment 371577 [details] Patch Attachment 371577 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12405324 New failing tests: imported/blink/fast/canvas/bug382588.html
EWS Watchlist
Comment 4 2019-06-07 07:21:10 PDT
Created attachment 371586 [details] Archive of layout-test-results from ews211 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews211 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Yusuke Suzuki
Comment 5 2020-06-12 20:37:00 PDT
Comment on attachment 371577 [details] Patch Maybe this is not needed...?
Saam Barati
Comment 6 2020-06-16 00:17:47 PDT
This is already the case.
Note You need to log in before you can comment on or make changes to this bug.