Bug 198380

Summary: [iOS] UIProcess' background task expiration handler may get called after the app is foreground again
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2019-05-30 10:26:48 PDT
UIProcess' background task expiration handler may get called after the app is foreground again. When this happens, we already have a foreground assertion on behalf of the WebContent process, and the view is visible. We would send the WillSuspendImminently IPC to the WebContent process, which would freeze its layers, even though it is visible on screen.
Attachments
Patch (3.34 KB, patch)
2019-05-30 10:29 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (4.44 KB, patch)
2019-06-02 14:55 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (3.41 KB, patch)
2019-06-04 08:30 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-05-30 10:27:07 PDT
<rdar://problem/49762471>
Chris Dumez
Comment 2 2019-05-30 10:29:48 PDT
Created attachment 370951 [details] Patch
Geoffrey Garen
Comment 3 2019-05-30 11:04:14 PDT
Comment on attachment 370951 [details] Patch r=me
WebKit Commit Bot
Comment 4 2019-05-30 12:34:25 PDT
Comment on attachment 370951 [details] Patch Clearing flags on attachment: 370951 Committed r245899: <https://trac.webkit.org/changeset/245899>
WebKit Commit Bot
Comment 5 2019-05-30 12:34:27 PDT
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 6 2019-05-31 16:11:08 PDT
Reverted r245899 for reason: Seems to be causing crashes on iosmac Committed r245992: <https://trac.webkit.org/changeset/245992>
Chris Dumez
Comment 7 2019-06-02 14:55:42 PDT
Created attachment 371163 [details] Patch
Chris Dumez
Comment 8 2019-06-02 14:58:45 PDT
Comment on attachment 371163 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371163&action=review > Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:165 > +#if !PLATFORM(IOSMAC) Temporarily disabling on IOSMAC due to <rdar://problem/51313780>.
Chris Dumez
Comment 9 2019-06-04 08:30:48 PDT
Created attachment 371284 [details] Patch
WebKit Commit Bot
Comment 10 2019-06-04 08:46:51 PDT
Comment on attachment 371284 [details] Patch Clearing flags on attachment: 371284 Committed r246064: <https://trac.webkit.org/changeset/246064>
WebKit Commit Bot
Comment 11 2019-06-04 08:46:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.