Bug 198202

Summary: [iOS] WebPage::positionInformation() may set InteractionInformationAtPosition.isImage to true but leave image unset
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: HTML EditingAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews121 for ios-simulator-wk2
none
Patch
none
Patch none

Said Abou-Hallawa
Reported 2019-05-23 18:15:44 PDT
One case for this to happen is the image dimension = { 1, 1 }.
Attachments
Patch (23.98 KB, patch)
2019-05-23 18:18 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.54 MB, application/zip)
2019-05-23 19:59 PDT, EWS Watchlist 		no flags
Details
Patch (26.42 KB, patch)
2019-05-24 17:06 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (26.37 KB, patch)
2019-05-25 11:21 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2019-05-23 18:18:59 PDT
Created attachment 370537 [details] Patch
Said Abou-Hallawa
Comment 2 2019-05-23 18:20:35 PDT
<rdar://problem/50711206>
EWS Watchlist
Comment 3 2019-05-23 19:59:46 PDT
Comment on attachment 370537 [details] Patch Attachment 370537 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12274410 New failing tests: editing/selection/character-granularity-rect.html
EWS Watchlist
Comment 4 2019-05-23 19:59:47 PDT
Created attachment 370555 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5
Tim Horton
Comment 5 2019-05-23 21:23:39 PDT
Comment on attachment 370537 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370537&action=review > Source/WebKit/ChangeLog:18 > + Since WebPage::positionInformation() is a little bit difficult to read Hah! I’ve been meaning to do this for years, glad someone finally did.
Said Abou-Hallawa
Comment 6 2019-05-24 17:06:34 PDT
Created attachment 370608 [details] Patch
Said Abou-Hallawa
Comment 7 2019-05-25 11:21:47 PDT
Created attachment 370637 [details] Patch
Tim Horton
Comment 8 2019-05-29 13:25:49 PDT
Comment on attachment 370637 [details] Patch This is mostly a rubber-stamp since it's hard to read around the moved code.
WebKit Commit Bot
Comment 9 2019-05-29 15:07:40 PDT
Comment on attachment 370637 [details] Patch Clearing flags on attachment: 370637 Committed r245872: <https://trac.webkit.org/changeset/245872>
WebKit Commit Bot
Comment 10 2019-05-29 15:07:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.