Bug 198130

Summary: Use a different variable when testing for Xcode context in generate-xcfilelists
Product: WebKit Reporter: Keith Rollin <krollin>
Component: Tools / TestsAssignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, glenn, jbedard, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=197622
Attachments:
Description Flags
Patch none

Keith Rollin
Reported 2019-05-22 10:42:59 PDT
The generate-xcfilelists script can run stand-alone or in the context of Xcode. There are a couple of places where it helps to know which context is current. To determine the context, genreate-xfilelists checks an environment variable that should be defined only when Xcode is running. The variable chosen was XCODE_INSTALL_PATH. It turns out that this variable is not always defined. Therefore, switch to checking XCODE_PRODUCT_BUILD_VERSION.
Attachments
Patch (2.37 KB, patch)
2019-05-22 10:46 PDT, Keith Rollin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-05-22 10:43:18 PDT
<rdar://problem/51032752>
Keith Rollin
Comment 2 2019-05-22 10:46:23 PDT
Created attachment 370418 [details] Patch
Keith Rollin
Comment 3 2019-05-22 10:50:41 PDT
I should have mentioned: the upshot of using XCODE_INSTALL_PATH and its being unexpectedly undefined was that an assertion was thrown when it shouldn't have been causing the xcfilelist-checking operation to abort, which also aborted the build.
WebKit Commit Bot
Comment 4 2019-05-22 12:09:35 PDT
Comment on attachment 370418 [details] Patch Clearing flags on attachment: 370418 Committed r245635: <https://trac.webkit.org/changeset/245635>
WebKit Commit Bot
Comment 5 2019-05-22 12:09:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.