Bug 197955

Summary:

Web Inspector: Dark Mode: Fix colors in network table waterfall container

Product:

WebKit

Reporter:

Jamal Nasser <jamaln>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Screenshot] Bug	none
[Screenshot] Patch applied	none
Patch	none
Patch	none
Patch	none
Patch	none

Jamal Nasser

Reported 2019-05-16 12:27:45 PDT

Created attachment 370055 [details] [Screenshot] Bug The waterfall-container area under the network tab is currently using colors that don't suit the dark mode well. Specifically, changed the blue circles to be brighter and the 'fullscreen' grey area to be dimmer. The latter is also now using a preexisting color variable instead of a custom color.

Attachments
[Screenshot] Bug (86.12 KB, image/png) 2019-05-16 12:27 PDT, Jamal Nasser	no flags	Details
[Screenshot] Patch applied (130.42 KB, image/png) 2019-05-16 12:28 PDT, Jamal Nasser	no flags	Details
Patch (1.95 KB, patch) 2019-05-16 12:44 PDT, Jamal Nasser	no flags	Details Formatted Diff Diff
Patch (3.13 KB, patch) 2019-05-17 13:09 PDT, Jamal Nasser	no flags	Details Formatted Diff Diff
Patch (3.12 KB, patch) 2019-05-17 13:17 PDT, Jamal Nasser	no flags	Details Formatted Diff Diff
Patch (2.39 KB, patch) 2019-05-17 13:41 PDT, Jamal Nasser	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Jamal Nasser

Comment 1 2019-05-16 12:28:24 PDT

Created attachment 370056 [details] [Screenshot] Patch applied

Jamal Nasser

Comment 2 2019-05-16 12:44:11 PDT

Created attachment 370060 [details] Patch

Devin Rousso

Comment 3 2019-05-16 14:11:58 PDT

Comment on attachment 370060 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370060&action=review > Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.css:211 > + background-color: var(--dashboard-background-color); We probably don't want to reuse a variable like this, since the fullscreen event area has nothing to do with the dashboard. Also, FWIW I think we might want to make it slightly lighter, almost halfway between what you have now `hsl(0, 0%, 36%)` and what was there before `hsla(0, 0%, 75%, 0.75)`. Maybe a regular `grey` or a `hsla(0, 0%, 50%)`?

Devin Rousso

Comment 4 2019-05-16 14:12:22 PDT

Jamal Nasser

Comment 5 2019-05-17 13:09:03 PDT

Created attachment 370137 [details] Patch

Jamal Nasser

Comment 6 2019-05-17 13:13:55 PDT

(In reply to Devin Rousso from comment #3) > Comment on attachment 370060 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=370060&action=review > > > Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.css:211 > > + background-color: var(--dashboard-background-color); > > We probably don't want to reuse a variable like this, since the fullscreen > event area has nothing to do with the dashboard. Also, FWIW I think we > might want to make it slightly lighter, almost halfway between what you have > now `hsl(0, 0%, 36%)` and what was there before `hsla(0, 0%, 75%, 0.75)`. > Maybe a regular `grey` or a `hsla(0, 0%, 50%)`? 50% is a little too bright in my opinion. This is what 40% looks like: https://i.imgur.com/d8Q1V8A.png I think that fits better than 50%: https://i.imgur.com/Rz0RRuV.png

Jamal Nasser

Comment 7 2019-05-17 13:17:51 PDT

Created attachment 370139 [details] Patch

Devin Rousso

Comment 8 2019-05-17 13:33:56 PDT

Comment on attachment 370139 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370139&action=review r=me, nice fix! > Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.css:211 > + background-color: var(--network-waterfall-fullscreen-area-color); There's no reason to make a variable if it's only really used once (or even twice). Please just inline it.

Jamal Nasser

Comment 9 2019-05-17 13:41:17 PDT

Created attachment 370143 [details] Patch

WebKit Commit Bot

Comment 10 2019-05-17 16:07:27 PDT

Comment on attachment 370143 [details] Patch Clearing flags on attachment: 370143 Committed r245484: <https://trac.webkit.org/changeset/245484>

WebKit Commit Bot

Comment 11 2019-05-17 16:07:29 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 12 2019-05-17 16:08:24 PDT

<rdar://problem/50909676>

Note You need to log in before you can comment on or make changes to this bug.