Bug 197682

Summary: [WebGPU] Validate GPUComputePassEncoder.dispatch to prevent DOS on macOS
Product: WebKit Reporter: Justin Fan <justin_fan>
Component: WebGPUAssignee: Justin Fan <justin_fan>
Status: NEW    
Severity: Normal CC: dino, ews-watchlist, graouts, jonlee, kondapallykalyan, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mmaxfield: review-

Justin Fan
Reported 2019-05-07 18:04:08 PDT
[WebGPU] Limit threadsPerThreadGroup for GPUComputePassEncoder.dispatch to prevent DOS on macOS
Attachments
Patch (1.94 KB, patch)
2019-05-08 13:48 PDT, Justin Fan 		mmaxfield: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Justin Fan
Comment 1 2019-05-08 13:48:03 PDT
Created attachment 369419 [details] Patch
Myles C. Maxfield
Comment 2 2019-05-08 13:56:29 PDT
Comment on attachment 369419 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369419&action=review > Source/WebCore/platform/graphics/gpu/cocoa/GPUComputePassEncoderMetal.mm:97 > + LOG(WebGPU, "GPUComputePassEncoder::dispatch(): Threadgroup dispatch size too large!"); a single thread can make the GPU hang. This check is not sufficient to solve the problem nor necessary to solve the problem. We need to solve DOS attacks at a more fundamental level. Also this constant would have to be hardware-dependent.
Myles C. Maxfield
Comment 3 2019-05-08 13:57:47 PDT
Comment on attachment 369419 [details] Patch This is fundamentally the wrong approach to solving this problem.
Radar WebKit Bug Importer
Comment 4 2019-05-14 15:08:53 PDT
<rdar://problem/50784837>
Note You need to log in before you can comment on or make changes to this bug.