Bug 196955

Summary: Add a query string nonce to LayoutTests/http/tests/adClickAttribution/send-attribution-conversion-request.html to address flakiness
Product: WebKit Reporter: John Wilander <wilander>
Component: WebCore Misc.Assignee: John Wilander <wilander>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=196838
Attachments:
Description Flags
Patch for landing none

John Wilander
Reported 2019-04-15 20:38:54 PDT
As noted in comment https://bugs.webkit.org/show_bug.cgi?id=196838#c18, LayoutTests/http/tests/adClickAttribution/send-attribution-conversion-request.html is a flaky failure. We should add a nonce to the file created so that test runs cannot mess with each other.
Attachments
Patch for landing (7.54 KB, patch)
2019-04-15 20:44 PDT, John Wilander 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
John Wilander
Comment 1 2019-04-15 20:44:06 PDT
Created attachment 367494 [details] Patch for landing
Radar WebKit Bug Importer
Comment 2 2019-04-15 20:46:52 PDT
<rdar://problem/49928896>
Radar WebKit Bug Importer
Comment 3 2019-04-15 20:47:03 PDT
<rdar://problem/49928898>
WebKit Commit Bot
Comment 4 2019-04-15 21:24:29 PDT
Comment on attachment 367494 [details] Patch for landing Clearing flags on attachment: 367494 Committed r244325: <https://trac.webkit.org/changeset/244325>
WebKit Commit Bot
Comment 5 2019-04-15 21:24:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.