Bug 196142

Summary: [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
Product: WebKit Reporter: Frédéric Wang Nélar <fred.wang>
Component: MathMLAssignee: Frédéric Wang Nélar <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, commit-queue, dbarton, ews-watchlist, mcatanzaro, rbuis, rniwa, rwlbuis
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 195797, 281206    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Frédéric Wang Nélar
Reported 2019-03-22 04:37:59 PDT
The MathML refresh CG decided to remove these values from MathML Core: https://github.com/mathml-refresh/mathml/issues/4 In this bug, we will also introduce a runtime flag to disable more deprecated MathML features later.
Attachments
Patch (18.21 KB, patch)
2019-03-22 04:56 PDT, Frédéric Wang Nélar 		no flags
DetailsFormatted DiffDiff
Patch (22.42 KB, patch)
2019-03-22 07:16 PDT, Frédéric Wang Nélar 		no flags
DetailsFormatted DiffDiff
Patch (20.81 KB, patch)
2019-03-23 22:16 PDT, Frédéric Wang Nélar 		no flags
DetailsFormatted DiffDiff
Patch (20.85 KB, patch)
2019-03-24 04:24 PDT, Frédéric Wang Nélar 		no flags
DetailsFormatted DiffDiff
Patch (20.62 KB, patch)
2019-03-29 02:59 PDT, Frédéric Wang Nélar 		no flags
DetailsFormatted DiffDiff
Patch (20.84 KB, patch)
2019-05-02 01:48 PDT, Frédéric Wang Nélar 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Frédéric Wang Nélar
Comment 1 2019-03-22 04:56:41 PDT
Created attachment 365712 [details] Patch
Frédéric Wang Nélar
Comment 2 2019-03-22 07:16:00 PDT
Created attachment 365723 [details] Patch
Ryosuke Niwa
Comment 3 2019-03-22 19:50:53 PDT
Comment on attachment 365723 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365723&action=review > Source/WebCore/mathml/MathMLFractionElement.cpp:58 > + if (!document().settings().deprecatedMathMLEnabled()) { This check isn't right. What we want is something like coreMathMLEnabled, which is disabled by default and enabled on GTK+/WPE. > Source/WebCore/page/Settings.yaml:824 > +deprecatedMathMLEnabled: > + initial: false We don't want to disable this feature in WebKitLegacy. In fact iBooks uses WebKitLegacy. In fact, we should keep the initial true and only disable non-core MathML in GTK+/WPE ports. > Source/WebKit/Shared/WebPreferences.yaml:1636 > + category: experimental This categorization isn't right. Having non-Core MathML feature is definitely not experimental. On the contrary, disabling those features is experimental. This problem goes away one we replace this with CoreMathMLEnabled instead.
Frédéric Wang Nélar
Comment 4 2019-03-23 22:16:54 PDT
Created attachment 365824 [details] Patch
Frédéric Wang Nélar
Comment 5 2019-03-24 04:24:47 PDT
Created attachment 365826 [details] Patch
Rob Buis
Comment 6 2019-03-29 02:12:11 PDT
Comment on attachment 365826 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365826&action=review Patch LGTM. > Source/WebCore/ChangeLog:9 > + adds a condition to disable thin", "thick", "medium" values of thin misses an opening '"'. > LayoutTests/imported/w3c/ChangeLog:9 > + adds a condition to disable thin", "thick", "medium" values of Ditto.
Frédéric Wang Nélar
Comment 7 2019-03-29 02:59:00 PDT
Created attachment 366260 [details] Patch
Frédéric Wang Nélar
Comment 8 2019-03-29 02:59:58 PDT
(In reply to Rob Buis from comment #6) > Comment on attachment 365826 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=365826&action=review > > Patch LGTM. > > > Source/WebCore/ChangeLog:9 > > + adds a condition to disable thin", "thick", "medium" values of > > thin misses an opening '"'. > > > LayoutTests/imported/w3c/ChangeLog:9 > > + adds a condition to disable thin", "thick", "medium" values of > > Ditto. Thanks. I fixed the change logs and also resolved merge conflicts after https://trac.webkit.org/changeset/243643/webkit ; hopefully this is still working.
Rob Buis
Comment 9 2019-04-02 01:55:45 PDT
Comment on attachment 366260 [details] Patch This looks good to me, but I would like others to review the new runtime flag, given earlier discussion.
Frédéric Wang Nélar
Comment 10 2019-04-24 08:59:21 PDT
(In reply to Rob Buis from comment #9) > Comment on attachment 366260 [details] > Patch > > This looks good to me, but I would like others to review the new runtime > flag, given earlier discussion. @Ryosuke Are you happy with the latest version of the patch?
Frédéric Wang Nélar
Comment 11 2019-05-02 01:48:44 PDT
Created attachment 368768 [details] Patch
WebKit Commit Bot
Comment 12 2019-05-02 03:12:20 PDT
Comment on attachment 368768 [details] Patch Clearing flags on attachment: 368768 Committed r244869: <https://trac.webkit.org/changeset/244869>
WebKit Commit Bot
Comment 13 2019-05-02 03:12:21 PDT
All reviewed patches have been landed. Closing bug.
Michael Catanzaro
Comment 14 2019-05-02 08:19:29 PDT
Please CC webkitgtk-bugs for GTK/WPE bugs. We need to maintain web compat with Safari, so if Safari will retain these features, that means we should as well, however ill-advised....
Radar WebKit Bug Importer
Comment 15 2019-05-02 15:35:43 PDT
<rdar://problem/50424871>
Note You need to log in before you can comment on or make changes to this bug.