Bug 194919

Summary: webkitpy: Forward HOME to XPC processes
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED INVALID    
Severity: Normal CC: ap, ews-watchlist, glenn, lforschler
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jonathan Bedard
Reported 2019-02-21 14:11:57 PST
I think we should be forwarding the HOME environment variable child XPC processes, although I need to do a bit more testing to verify.
Attachments
Patch (1.36 KB, patch)
2019-02-21 14:15 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2019-02-21 14:12:41 PST
<rdar://problem/48135951>
Jonathan Bedard
Comment 2 2019-02-21 14:15:55 PST
Created attachment 362643 [details] Patch
Alexey Proskuryakov
Comment 3 2019-02-21 15:30:52 PST
Comment on attachment 362643 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362643&action=review > Tools/Scripts/webkitpy/port/driver.py:415 > + environment['__XPC_HOME'] = environment.get('HOME') I don't understand why this became necessary now. Did you reproduce the problem, and see it fixed with this change? Even if so, we probably need better understanding of the problem than what I saw documented yet.
Jonathan Bedard
Comment 4 2019-02-21 16:40:13 PST
(In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 362643 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=362643&action=review > > > Tools/Scripts/webkitpy/port/driver.py:415 > > + environment['__XPC_HOME'] = environment.get('HOME') > > I don't understand why this became necessary now. > > Did you reproduce the problem, and see it fixed with this change? Even if > so, we probably need better understanding of the problem than what I saw > documented yet. Sorry, no, I have not yet been able to reproduce the problem. I just wanted to draft the patch, I didn't intend to put it up for review yet, actually.
Jonathan Bedard
Comment 5 2019-03-07 14:14:37 PST
Upon further investigation, this change is not needed. Closing this bug.
Note You need to log in before you can comment on or make changes to this bug.