Bug 194826

Summary: [ Mac WK2 iOS ] Layout Test http/tests/resourceLoadStatistics/do-not-block-top-level-navigation-redirect.html is a flaky timeout
Product: WebKit Reporter: Shawn Roberts <sroberts>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: REOPENED    
Severity: Normal CC: bfulgham, commit-queue, lforschler, webkit-bot-watchers-bugzilla, webkit-bug-importer, wilander, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Shawn Roberts
Reported 2019-02-19 13:18:13 PST
The following layout test is failing on Mac WK2 iOS Simulator http/tests/resourceLoadStatistics/do-not-block-top-level-navigation-redirect.html Probable cause: Test is a flaky failure as of r231008 in which the test was changed. Prior revisions are 100% failure. Reproduced locally with: run-webkit-tests http/tests/resourceLoadStatistics/do-not-block-top-level-navigation-redirect.html --ios-simulator --debug --iterations 5000 -f run-webkit-tests http/tests/resourceLoadStatistics/do-not-block-top-level-navigation-redirect.html --debug --iterations 5000 -f run-webkit-tests http/tests/resourceLoadStatistics/do-not-block-top-level-navigation-redirect.html --iterations 5000 -f Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2FresourceLoadStatistics%2Fdo-not-block-top-level-navigation-redirect.html Diff: --- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/http/tests/resourceLoadStatistics/do-not-block-top-level-navigation-redirect-expected.txt +++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/http/tests/resourceLoadStatistics/do-not-block-top-level-navigation-redirect-actual.txt @@ -1 +1,5 @@ -PASSED: Cookie successfully set +#PID UNRESPONSIVE - com.apple.WebKit.WebContent.Development (pid 55416) +FAIL: Timed out waiting for notifyDone to be called + +#EOF +#EOF
Attachments
Patch (2.48 KB, patch)
2019-02-19 13:38 PST, Shawn Roberts 		no flags
DetailsFormatted DiffDiff
Patch (2.62 KB, patch)
2019-02-19 13:56 PST, Shawn Roberts 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-02-19 13:19:02 PST
<rdar://problem/48212209>
Shawn Roberts
Comment 2 2019-02-19 13:38:56 PST
Created attachment 362422 [details] Patch
Shawn Roberts
Comment 3 2019-02-19 13:56:14 PST
Created attachment 362424 [details] Patch
Brent Fulgham
Comment 4 2019-02-19 14:02:24 PST
Comment on attachment 362424 [details] Patch r=me
WebKit Commit Bot
Comment 5 2019-02-19 14:28:09 PST
Comment on attachment 362424 [details] Patch Clearing flags on attachment: 362424 Committed r241773: <https://trac.webkit.org/changeset/241773>
WebKit Commit Bot
Comment 6 2019-02-19 14:28:11 PST
All reviewed patches have been landed. Closing bug.
Shawn Roberts
Comment 7 2019-02-19 14:29:20 PST
Re opening while waiting for a fix.
Shawn Roberts
Comment 8 2019-03-08 14:45:04 PST
Additional steps for repro: Initially Mojave WK2 appeared on the dashboard for the first time as a timeout. Previously it appears that Mac WK2 Debug had been a flaky timeout for its visible history in dashboard. Doing a search on trac it appears test had been added in r231008, and modified in 234440, so after I got a timeout in 234440, started my testing from 231008 241719 --iterations 5000. 3 of 5000 timed out 234440 2 timeouts 231008 1 timeout 231007 Added --exit-after-n-failures=25: 25 timeouts. Mojave WK2 Debug --iterations 5000 241760 2 of 5000 timed out 230987 --exit-after-n-failures=25: 25 timeouts.
Shawn Roberts
Comment 9 2019-04-03 14:09:11 PDT
Correction, this is not a regression. Test has been a flaky timeout since the test was added in https://trac.webkit.org/changeset/231008/webkit
Note You need to log in before you can comment on or make changes to this bug.