Bug 194730

Summary: NetworkLoad should cancel its task at destruction time
Product: WebKit Reporter: youenn fablet <youennf>
Component: Page LoadingAssignee: youenn fablet <youennf>
Status: RESOLVED WONTFIX    
Severity: Normal CC: achristensen, beidson, cdumez, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch achristensen: review-

youenn fablet
Reported 2019-02-15 16:14:36 PST
NetworkLoad should cancel its task at destruction time
Attachments
Patch (1.64 KB, patch)
2019-02-15 16:17 PST, youenn fablet 		achristensen: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-02-15 16:17:22 PST
Created attachment 362176 [details] Patch
Radar WebKit Bug Importer
Comment 2 2019-02-15 16:17:42 PST
<rdar://problem/48128564>
Geoffrey Garen
Comment 3 2019-02-15 16:24:30 PST
Comment on attachment 362176 [details] Patch r=me
Alex Christensen
Comment 4 2019-02-15 16:26:50 PST
Comment on attachment 362176 [details] Patch Nope. We don't want to do this. When the task is destroyed it will effectively cancel. What we want to do instead is null check m_client in NetworkDataTask::shouldCaptureExtraNetworkLoadMetrics
youenn fablet
Comment 5 2019-02-15 16:38:55 PST
WONTFIX for now, let's do null check and revisit this issue if needed.
youenn fablet
Comment 6 2019-02-15 16:41:46 PST
In the meantime, I filed https://bugs.webkit.org/show_bug.cgi?id=194732.
Note You need to log in before you can comment on or make changes to this bug.