Bug 194563

Summary:

Fix the Windows build after r241320

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

WebCore Misc.

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED CONFIGURATION CHANGED

Severity:

Normal

CC:

jlewis3, ryanhaddad, tsavell, webkit-bug-importer

Priority:

Keywords:

DoNotImportToRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Wenson Hsieh

Reported 2019-02-12 16:22:09 PST

Filing a bug so I can test my change against the Windows EWS bot.

Attachments
Patch (1.78 KB, patch) 2019-02-12 16:25 PST, Wenson Hsieh	no flags	Details Formatted Diff Diff
Patch (1.74 KB, patch) 2019-02-12 16:26 PST, Wenson Hsieh	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Wenson Hsieh

Comment 1 2019-02-12 16:25:39 PST

c:\cygwin\home\buildbot\worker\win10-debug\build\source\webcore\page\frame.cpp(689): error C2220: warning treated as error - no 'object' file generated [C:\cygwin\home\buildbot\worker\win10-debug\build\WebKitBuild\Debug\Source\WebCore\WebCore.vcxproj] c:\cygwin\home\buildbot\worker\win10-debug\build\source\webcore\page\frame.cpp(689): warning C4715: 'WebCore::Frame::requestDOMPasteAccess': not all control paths return a value [C:\cygwin\home\buildbot\worker\win10-debug\build\WebKitBuild\Debug\Source\WebCore\WebCore.vcxproj]

Wenson Hsieh

Comment 2 2019-02-12 16:25:47 PST

Created attachment 361861 [details] Patch

Wenson Hsieh

Comment 3 2019-02-12 16:26:37 PST

Created attachment 361862 [details] Patch

Wenson Hsieh

Comment 4 2019-02-12 17:08:10 PST

It looks like Alex just landed a fix for this in r241331.

Note You need to log in before you can comment on or make changes to this bug.