Bug 194270

Summary: JITExecutable should not try to mmap executable memory without entitlement
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: JavaScriptCoreAssignee: Keith Miller <keith_miller>
Status: NEW    
Severity: Normal CC: ews-watchlist, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch saam: review+

Keith Miller
Reported 2019-02-04 19:26:10 PST
JITExecutable should not try to mmap executable memory without entitlement
Attachments
Patch (2.30 KB, patch)
2019-02-04 19:28 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (2.29 KB, patch)
2019-02-04 19:41 PST, Keith Miller 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2019-02-04 19:28:56 PST
Created attachment 361152 [details] Patch
Keith Miller
Comment 2 2019-02-04 19:41:21 PST
Created attachment 361153 [details] Patch
Saam Barati
Comment 3 2019-02-04 19:44:34 PST
Comment on attachment 361153 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361153&action=review r=me > Source/JavaScriptCore/ChangeLog:10 > + We try to use our one time token to map JIT memory if we are not > + going to use the JIT in a process. If we never had the This sentence makes it seem like we only do this if we don't have the entitlement. I think you can make it clearer.
Note You need to log in before you can comment on or make changes to this bug.