Bug 194265

Summary: vp8e_mr_alloc_mem() leaks LOWER_RES_FRAME_INFO if second memory allocation fails
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebRTCAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.chromium.org/p/webrtc/issues/detail?id=10289
https://bugs.chromium.org/p/webm/issues/detail?id=1596
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2019-02-04 18:16:27 PST
vp8e_mr_alloc_mem() leaks LOWER_RES_FRAME_INFO if second memory allocation fails via clang static analyzer: Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp8/vp8_cx_iface.c:589:5: warning: Value stored to 'res' is never read res = VPX_CODEC_MEM_ERROR; ^ ~~~~~~~~~~~~~~~~~~~ Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp8/vp8_cx_iface.c:592:27: warning: Access to field 'mb_info' results in a dereference of a null pointer (loaded from variable 'shared_mem_loc') shared_mem_loc->mb_info = ~~~~~~~~~~~~~~ ^ Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp8/vp8_cx_iface.c:595:11: warning: Potential leak of memory pointed to by 'shared_mem_loc' res = VPX_CODEC_MEM_ERROR; ^~~~~~~~~~~~~~~~~~~ 3 warnings generated.
Attachments
Patch v1 (4.12 KB, patch)
2019-02-04 18:25 PST, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2019-02-04 18:25:25 PST
Created attachment 361148 [details] Patch v1
Radar WebKit Bug Importer
Comment 2 2019-02-04 18:41:27 PST
<rdar://problem/47808154>
WebKit Commit Bot
Comment 3 2019-02-04 19:25:00 PST
Comment on attachment 361148 [details] Patch v1 Clearing flags on attachment: 361148 Committed r240961: <https://trac.webkit.org/changeset/240961>
WebKit Commit Bot
Comment 4 2019-02-04 19:25:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.