Bug 194231

Summary: when lowering AssertNotEmpty, create the value before creating the patchpoint
Product: WebKit Reporter: Robin Morisset <rmorisset>
Component: JavaScriptCoreAssignee: Robin Morisset <rmorisset>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Robin Morisset
Reported 2019-02-04 11:12:33 PST
rdar://problem/46447987
Attachments
Patch (3.03 KB, patch)
2019-02-04 13:48 PST, Robin Morisset 		no flags
DetailsFormatted DiffDiff
Patch (3.08 KB, patch)
2019-02-04 13:53 PST, Robin Morisset 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Robin Morisset
Comment 1 2019-02-04 13:48:37 PST
Created attachment 361094 [details] Patch
Robin Morisset
Comment 2 2019-02-04 13:53:31 PST
Created attachment 361095 [details] Patch
EWS Watchlist
Comment 3 2019-02-04 16:35:02 PST
Comment on attachment 361095 [details] Patch Attachment 361095 [details] did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/11030286 New failing tests: stress/ftl-get-by-id-getter-exception-interesting-live-state.js.ftl-eager apiTests
Robin Morisset
Comment 4 2019-02-04 17:24:58 PST
I could not reproduce this failure, and according to sbarati@apple.com, this test is known to be flaky.
Saam Barati
Comment 5 2019-02-04 17:30:15 PST
Comment on attachment 361095 [details] Patch r=me
WebKit Commit Bot
Comment 6 2019-02-04 17:36:33 PST
Comment on attachment 361095 [details] Patch Clearing flags on attachment: 361095 Committed r240959: <https://trac.webkit.org/changeset/240959>
WebKit Commit Bot
Comment 7 2019-02-04 17:36:35 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.