Bug 194115

Summary: Web Inspector: Timeline Detail Views do not reset properly when new time range selection contains nothing
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix hi: review+

Joseph Pecoraro
Reported 2019-01-31 14:35:12 PST
Timeline Detail Views do not reset properly when new time range selection contains nothing Steps to Reproduce: 1. Inspect this page 2. Show Memory Timeline 3. Make a short recording 4. Select an empty time range (like 4s-5s) => Memory Detail View circle charts still filled Notes: - layout() should be resetting instead of bailing
Attachments
[PATCH] Proposed Fix (3.66 KB, patch)
2019-01-31 14:59 PST, Joseph Pecoraro 		hi: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-01-31 14:35:43 PST
<rdar://problem/47716693>
Joseph Pecoraro
Comment 2 2019-01-31 14:59:07 PST
Created attachment 360791 [details] [PATCH] Proposed Fix
Devin Rousso
Comment 3 2019-01-31 15:15:39 PST
Comment on attachment 360791 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=360791&action=review rs=me > Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js:83 > + this.clear(); I think this deserves a ChangeLog comment. Something like "Calling `.clear()` will remove all UI from the selected range, but keep any non-range-specific values (e.g. maximum usage) as they were in the UI.".
Joseph Pecoraro
Comment 4 2019-02-01 13:26:37 PST
https://trac.webkit.org/changeset/240869/webkit
Note You need to log in before you can comment on or make changes to this bug.