Bug 194092

Summary: [SOUP] Improve use of PAL::SessionID in WebKitCookieManager
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, cgarcia, commit-queue, ews-watchlist, gustavo, mcatanzaro, webkit-bug-importer
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2019-01-31 08:52:12 PST
Improve use of PAL::SessionID in WebKitCookieManager. Always get it from the data store instead of assuming the default session ID, and add a helper function for this. We could cache it there too, just not sure it's worth it.
Attachments
Patch (8.49 KB, patch)
2019-01-31 08:54 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2019-01-31 08:54:19 PST
Created attachment 360731 [details] Patch
EWS Watchlist
Comment 2 2019-01-31 08:57:13 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
WebKit Commit Bot
Comment 3 2019-02-01 08:51:19 PST
Comment on attachment 360731 [details] Patch Clearing flags on attachment: 360731 Committed r240850: <https://trac.webkit.org/changeset/240850>
WebKit Commit Bot
Comment 4 2019-02-01 08:51:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.