Bug 193913

Summary: [macOS] Crash when control-clicking or copying text rendered with a web font
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, dbates, ddkilzer, mitz, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Mac   
OS: macOS 10.13   
Attachments:
Description Flags
Patch
none
Patch none

Per Arne Vollan
Reported 2019-01-28 10:15:06 PST
This was caused by <https://trac.webkit.org/r239963>.
Attachments
Patch (1.39 KB, patch)
2019-01-28 10:18 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (1.39 KB, patch)
2019-01-28 10:28 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2019-01-28 10:15:27 PST
rdar://problem/47541039
Per Arne Vollan
Comment 2 2019-01-28 10:18:47 PST
Created attachment 360349 [details] Patch
mitz
Comment 3 2019-01-28 10:21:15 PST
Comment on attachment 360349 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360349&action=review > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:575 > +#if __MAC_OS_X_VERSION_MIN_REQUIRED <= 101300 Comparisons against VERSION_MIN_REQUIRED and VERSION_MAX_ALLOWED should always use either >= or <, never <= or >.
Per Arne Vollan
Comment 4 2019-01-28 10:28:50 PST
Created attachment 360354 [details] Patch
Per Arne Vollan
Comment 5 2019-01-28 10:29:29 PST
(In reply to mitz from comment #3) > Comment on attachment 360349 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=360349&action=review > > > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:575 > > +#if __MAC_OS_X_VERSION_MIN_REQUIRED <= 101300 > > Comparisons against VERSION_MIN_REQUIRED and VERSION_MAX_ALLOWED should > always use either >= or <, never <= or >. Thanks for reviewing! I have updated the patch.
Per Arne Vollan
Comment 6 2019-01-31 12:04:37 PST
I have confirmed locally that this patch fixes the crash.
Brent Fulgham
Comment 7 2019-01-31 13:15:38 PST
Comment on attachment 360354 [details] Patch r=me
Per Arne Vollan
Comment 8 2019-01-31 13:24:36 PST
Comment on attachment 360354 [details] Patch Thanks for reviewing!
WebKit Commit Bot
Comment 9 2019-01-31 13:41:04 PST
Comment on attachment 360354 [details] Patch Clearing flags on attachment: 360354 Committed r240810: <https://trac.webkit.org/changeset/240810>
WebKit Commit Bot
Comment 10 2019-01-31 13:41:06 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.