Bug 193847

Summary: Move parentProcessConnection from ChildProcess to {NetworkProcess, WebProcess, PluginProcess}
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED WONTFIX    
Severity: Normal CC: aestes, ggaren, sam, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2019-01-25 14:40:47 PST
Move parentProcessConnection from ChildProcess to {NetworkProcess, WebProcess, PluginProcess}
Attachments
Patch (17.61 KB, patch)
2019-01-25 14:42 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (17.66 KB, patch)
2019-01-25 15:53 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-01-25 14:42:07 PST
Created attachment 360168 [details] Patch
Alex Christensen
Comment 2 2019-01-25 15:47:28 PST
Comment on attachment 360168 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360168&action=review > Source/WebKit/NetworkProcess/NetworkProcess.cpp:161 > initialize(WTFMove(parameters)); > + > + m_connection = IPC::Connection::createClientConnection(parameters.connectionIdentifier, *this); This uses parameters after it has been moved from. Will fix.
Alex Christensen
Comment 3 2019-01-25 15:53:19 PST
Created attachment 360179 [details] Patch
Sam Weinig
Comment 4 2019-01-26 12:28:16 PST
Comment on attachment 360179 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360179&action=review > Source/WebKit/ChangeLog:8 > + This is paving the way for the NetworkProcess to be split into a NetworkProcess and set of NetworkConnectionToUIProcess containing the connections. Can you tell me more about the future here? Is the idea that NetworkProcess in the future will be system wide and will be able to communicate with multiple UIProcesses? If so, it seems like a better direction would be to make it so that NetworkProcess no longer derives from ChildProcess, since it's not a "child process" anymore.
Alex Christensen
Comment 5 2019-01-26 19:35:57 PST
Sam, this is a step towards exactly that, except we plan to have a system-wide NetworkProcess for only certain SPI users.
Sam Weinig
Comment 6 2019-01-27 15:04:10 PST
(In reply to Alex Christensen from comment #5) > Sam, this is a step towards exactly that, except we plan to have a > system-wide NetworkProcess for only certain SPI users. Ok, I then I think it makes sense to not make this change to ChildProcess, and just make this new "SystemWideNetworkService" not derive from ChildProcess, since it isn't a "child process" anymore.
Geoffrey Garen
Comment 7 2019-01-28 14:30:45 PST
Comment on attachment 360179 [details] Patch What are some of the behaviors of ChildProcess that NetworkProcess will still want after it has multiple UI process clients? And what behaviors would remain unique to ChildProcess, and unsupported by NetworkProcess? Could the shared behaviors meaningfully move into a shared base class named "AuxiliaryProcess"? Answering these questions might help us understand the class relationships.
Note You need to log in before you can comment on or make changes to this bug.