Bug 193596

Summary: Cleanup undo options
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED INVALID    
Severity: Normal CC: wenson_hsieh
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch wenson_hsieh: review+

Megan Gardner
Reported 2019-01-18 15:15:10 PST
Cleanup undo options
Attachments
Patch (2.77 KB, patch)
2019-01-18 15:18 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (2.77 KB, patch)
2019-01-18 16:04 PST, Megan Gardner 		wenson_hsieh: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2019-01-18 15:18:49 PST
Created attachment 359546 [details] Patch
Megan Gardner
Comment 2 2019-01-18 16:04:20 PST
Created attachment 359551 [details] Patch
Wenson Hsieh
Comment 3 2019-01-18 17:01:48 PST
Comment on attachment 359551 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359551&action=review > Source/WebKit/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=193596 Radar link? > Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:161 > +enum WKUndoOption { : uint8_t > Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:162 > + WKUndoTypeDefault = 0, Nit - extra space before 0 here. > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:5109 > + if (_suppressSelectionAssistantReasons.contains(WebKit::FocusedElementIsTransparentOrFullyClipped)) We probably want to return Smaller for WebKit::FocusedElementIsTooSmall too.
Megan Gardner
Comment 4 2021-08-17 17:48:14 PDT
Old and not relevant anymore.
Note You need to log in before you can comment on or make changes to this bug.