Bug 193298

Summary: [WebGPU] Add BindGroupBinding, BindGroupDescriptor, and BufferBinding dictionaries from API
Product: WebKit Reporter: Justin Fan <justin_fan>
Component: New BugsAssignee: Justin Fan <justin_fan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Justin Fan
Reported 2019-01-09 14:35:40 PST
[WebGPU] Add BindGroupBinding, BindGroupDescriptor, and BufferBinding dictionaries from API
Attachments
Patch (27.92 KB, patch)
2019-01-09 14:43 PST, Justin Fan 		no flags
DetailsFormatted DiffDiff
Patch (26.53 KB, patch)
2019-01-09 14:51 PST, Justin Fan 		no flags
DetailsFormatted DiffDiff
Patch for landing (28.24 KB, patch)
2019-01-10 11:01 PST, Justin Fan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Justin Fan
Comment 1 2019-01-09 14:43:54 PST
Created attachment 358742 [details] Patch
Justin Fan
Comment 2 2019-01-09 14:51:09 PST
Created attachment 358745 [details] Patch
Radar WebKit Bug Importer
Comment 3 2019-01-09 15:22:37 PST
<rdar://problem/47161058>
Dean Jackson
Comment 4 2019-01-09 16:30:33 PST
Comment on attachment 358745 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358745&action=review > Source/WebCore/Modules/webgpu/WebGPUBindGroupBinding.h:32 > +#include "WebGPUTextureView.h" > + No need for this blank line. > Source/WebCore/Modules/webgpu/WebGPUBindGroupDescriptor.h:33 > +#include "WebGPUBindGroupLayout.h" > + > +#include <wtf/Vector.h> No need for this blank line. > Source/WebCore/Modules/webgpu/WebGPUBufferBinding.h:30 > +#include "WebGPUBuffer.h" I think this file should #include RefPtr.h too. > Source/WebCore/platform/graphics/gpu/GPUBindGroupBinding.h:33 > +#include "GPUTexture.h" > + > +#include <wtf/Variant.h> No blank line. > Source/WebCore/platform/graphics/gpu/GPUBindGroupDescriptor.h:33 > +#include "GPUBindGroupLayout.h" > + > +#include <wtf/Vector.h> No blank line. Should probably also include Ref.h
Justin Fan
Comment 5 2019-01-10 11:01:15 PST
Created attachment 358807 [details] Patch for landing
WebKit Commit Bot
Comment 6 2019-01-10 11:59:24 PST
Comment on attachment 358807 [details] Patch for landing Clearing flags on attachment: 358807 Committed r239837: <https://trac.webkit.org/changeset/239837>
WebKit Commit Bot
Comment 7 2019-01-10 11:59:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.