Bug 193170

Summary: PlatformECKey should use a std::unique_ptr
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebCore Misc.Assignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, commit-queue, darin, don.olmstead, ggaren, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=193154
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2019-01-05 04:01:22 PST
PlatformECKey should use a std::unique_ptr. Although there are no known leaks of PlatformECKey, keeping it in a std::unique_ptr makes it much harder to leak by accident. This change is very similar to Bug 193154 which changed PlatformRSAKey to use a std::unique_ptr.
Attachments
Patch v1 (22.03 KB, patch)
2019-01-05 04:05 PST, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2019-01-05 04:05:56 PST
Created attachment 358436 [details] Patch v1
Radar WebKit Bug Importer
Comment 2 2019-01-06 02:53:26 PST
<rdar://problem/47070633>
WebKit Commit Bot
Comment 3 2019-01-07 12:30:19 PST
Comment on attachment 358436 [details] Patch v1 Clearing flags on attachment: 358436 Committed r239692: <https://trac.webkit.org/changeset/239692>
WebKit Commit Bot
Comment 4 2019-01-07 12:30:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.