Bug 193007

Summary: [WHLSL] Implement the NameResolver
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: WebGPUAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, fpizlo, jonlee, justin_fan, mmaxfield, rmorisset, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 192826    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
dino: review+
Patch for committing none

Myles C. Maxfield
Reported 2018-12-22 01:00:56 PST
Implement the NameResolver
Attachments
Patch (38.61 KB, patch)
2018-12-22 01:01 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (45.64 KB, patch)
2018-12-22 03:15 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (162.81 KB, patch)
2018-12-31 17:41 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (164.30 KB, patch)
2018-12-31 22:07 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (170.30 KB, patch)
2018-12-31 23:03 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (233.09 KB, patch)
2019-01-01 00:41 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (32.69 KB, patch)
2019-01-11 00:24 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (69.65 KB, patch)
2019-01-11 10:41 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (68.63 KB, patch)
2019-01-11 11:50 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (68.88 KB, patch)
2019-01-11 12:33 PST, Myles C. Maxfield 		dino: review+
DetailsFormatted DiffDiff
Patch for committing (71.55 KB, patch)
2019-01-11 19:53 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2018-12-22 01:01:29 PST
Created attachment 358021 [details] Patch
Myles C. Maxfield
Comment 2 2018-12-22 03:15:59 PST
Created attachment 358022 [details] Patch
Myles C. Maxfield
Comment 3 2018-12-31 17:41:23 PST
Created attachment 358157 [details] Patch
Myles C. Maxfield
Comment 4 2018-12-31 22:07:32 PST
Created attachment 358164 [details] Patch
Myles C. Maxfield
Comment 5 2018-12-31 23:03:50 PST
Created attachment 358167 [details] Patch
Myles C. Maxfield
Comment 6 2019-01-01 00:41:14 PST
Created attachment 358169 [details] Patch
Myles C. Maxfield
Comment 7 2019-01-11 00:24:05 PST
Created attachment 358883 [details] Patch
Myles C. Maxfield
Comment 8 2019-01-11 10:41:09 PST
Created attachment 358908 [details] Patch
Myles C. Maxfield
Comment 9 2019-01-11 11:50:27 PST
Created attachment 358922 [details] Patch
Myles C. Maxfield
Comment 10 2019-01-11 12:18:38 PST
Comment on attachment 358922 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358922&action=review > Source/WebCore/Modules/webgpu/WHLSL/WHLSLProgram.h:47 > bool append(AST::TypeDefinition&& typeDefinition) #include "WHLSLNameContext.h"
Myles C. Maxfield
Comment 11 2019-01-11 12:33:23 PST
Created attachment 358928 [details] Patch
Myles C. Maxfield
Comment 12 2019-01-11 19:53:52 PST
Created attachment 358977 [details] Patch for committing
Myles C. Maxfield
Comment 13 2019-01-11 22:26:27 PST
Committed r239896: <https://trac.webkit.org/changeset/239896>
Radar WebKit Bug Importer
Comment 14 2019-01-11 22:27:29 PST
<rdar://problem/47229039>
Note You need to log in before you can comment on or make changes to this bug.