Bug 192952

Summary: Add API test coverage for customUserAgent client setting and service workers
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Service WorkersAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, ews-watchlist, ggaren, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 192951    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2018-12-20 13:35:57 PST
Add API test coverage for customUserAgent client setting and service workers.
Attachments
Patch (5.73 KB, patch)
2018-12-20 13:39 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (5.73 KB, patch)
2018-12-20 16:10 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2018-12-20 13:39:26 PST
Created attachment 357861 [details] Patch
EWS Watchlist
Comment 2 2018-12-20 13:43:47 PST
Attachment 357861 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:545: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:551: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 3 2018-12-20 16:10:07 PST
Created attachment 357892 [details] Patch
Alex Christensen
Comment 4 2018-12-20 16:11:38 PST
Comment on attachment 357892 [details] Patch Great FIXME
EWS Watchlist
Comment 5 2018-12-20 16:12:59 PST
Attachment 357892 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:545: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:551: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 6 2018-12-20 17:24:41 PST
The commit-queue encountered the following flaky tests while processing attachment 357892 [details]: storage/indexeddb/objectstore-basics-workers.html bug 192965 (authors: beidson@apple.com, commit-queue@webkit.org, and mark.lam@apple.com) http/wpt/css/css-animations/start-animation-001.html bug 190903 (authors: dino@apple.com, fred.wang@free.fr, and graouts@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2018-12-20 17:25:24 PST
Comment on attachment 357892 [details] Patch Clearing flags on attachment: 357892 Committed r239480: <https://trac.webkit.org/changeset/239480>
WebKit Commit Bot
Comment 8 2018-12-20 17:25:26 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-12-20 17:26:29 PST
<rdar://problem/46888770>
Note You need to log in before you can comment on or make changes to this bug.