Bug 192915

Summary: Web Inspector: "E" icon on debugger dashboard is too close to current function name
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
[Image] With patch applied none

Nikita Vasilyev
Reported 2018-12-19 21:33:54 PST
When paused in the debugger, the current function name is too close to the “E” icon. There should be more padding. <rdar://problem/44535743>
Attachments
Patch (2.17 KB, patch)
2018-12-19 21:35 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
[Image] With patch applied (19.71 KB, image/png)
2018-12-19 21:35 PST, Nikita Vasilyev 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Nikita Vasilyev
Comment 1 2018-12-19 21:35:02 PST
Created attachment 357776 [details] Patch
Nikita Vasilyev
Comment 2 2018-12-19 21:35:33 PST
Created attachment 357777 [details] [Image] With patch applied
Matt Baker
Comment 3 2018-12-19 22:12:55 PST
Comment on attachment 357776 [details] Patch r=me
WebKit Commit Bot
Comment 4 2018-12-19 22:39:29 PST
Comment on attachment 357776 [details] Patch Clearing flags on attachment: 357776 Committed r239432: <https://trac.webkit.org/changeset/239432>
WebKit Commit Bot
Comment 5 2018-12-19 22:39:30 PST
All reviewed patches have been landed. Closing bug.
Joseph Pecoraro
Comment 6 2018-12-20 12:10:39 PST
Comment on attachment 357776 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357776&action=review > Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.css:168 > -body[dir=rtl] .dashboard.debugger > .location .function-icon { > +body[dir=rtl] .dashboard.debugger > .location :matches(.function-icon, .event-listener-icon) { Is there a more general class we can use here for any icon? What if it's a [P] Program/Script icon?
Matt Baker
Comment 7 2018-12-20 18:19:37 PST
Comment on attachment 357776 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357776&action=review >> Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.css:168 >> +body[dir=rtl] .dashboard.debugger > .location :matches(.function-icon, .event-listener-icon) { > > Is there a more general class we can use here for any icon? What if it's a [P] Program/Script icon? Actually we can probably drop the :matches part. DebuggerDashboardView.prototype._rebuildLocation will use an icon class name of "function-icon" by default, replacing it with event-listener-icon if it thinks we're in a user event handler. It will always be one or the other.
Matt Baker
Comment 8 2018-12-20 18:20:28 PST
(In reply to Matt Baker from comment #7) > Comment on attachment 357776 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=357776&action=review > > >> Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.css:168 > >> +body[dir=rtl] .dashboard.debugger > .location :matches(.function-icon, .event-listener-icon) { > > > > Is there a more general class we can use here for any icon? What if it's a [P] Program/Script icon? > > Actually we can probably drop the :matches part. > DebuggerDashboardView.prototype._rebuildLocation will use an icon class name > of "function-icon" by default, replacing it with event-listener-icon if it > thinks we're in a user event handler. It will always be one or the other. For example, breaking here will show a function-icon [f]: <script> debugger; </script>
Note You need to log in before you can comment on or make changes to this bug.