Bug 192814

Summary: clang-tidy: Use const reference for MediaTime parameter to prevent object copy
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: MediaAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dbates, eric.carlson, ews-watchlist, keith_miller, mark.lam, msaboff, rniwa, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1
none
Archive of layout-test-results from ews104 for mac-sierra-wk2 none

David Kilzer (:ddkilzer)
Reported 2018-12-18 11:03:00 PST
Running `clang-tidy -header-filter=.* -checks='-*,performance-*,-performance-noexcept-*' ...` on JavaScriptCore and WebCore source files found these unnecessary object copies in MediaTime function parameters in trunk revision r239112. Source/JavaScriptCore/runtime/JSCJSValue.h:554:42: warning: the parameter 't' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param] ALWAYS_INLINE JSValue jsNumber(MediaTime t) ^ const & Source/WebCore/bindings/js/JSDOMConvertNumbers.h:392:43: warning: the parameter 'value' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param] static JSC::JSValue convert(MediaTime value) ^ const &
Attachments
Patch v1 (2.45 KB, patch)
2018-12-18 11:04 PST, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews104 for mac-sierra-wk2 (3.31 MB, application/zip)
2018-12-18 12:49 PST, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2018-12-18 11:04:26 PST
Created attachment 357582 [details] Patch v1
Mark Lam
Comment 2 2018-12-18 11:19:24 PST
Comment on attachment 357582 [details] Patch v1 LGTM if EWS bots are happy.
EWS Watchlist
Comment 3 2018-12-18 12:49:23 PST
Comment on attachment 357582 [details] Patch v1 Attachment 357582 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10461730 New failing tests: fast/forms/datalist/datalist-textinput-suggestions-order.html
EWS Watchlist
Comment 4 2018-12-18 12:49:25 PST
Created attachment 357599 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
David Kilzer (:ddkilzer)
Comment 5 2018-12-18 13:27:09 PST
(In reply to Build Bot from comment #4) > Created attachment 357599 [details] > Archive of layout-test-results from ews104 for mac-sierra-wk2 > > The attached test failures were seen while running run-webkit-tests on the > mac-wk2-ews. > Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6 On further analysis, this appears to be a rare flaky crash that's unrelated to this change. I filed <rdar://problem/46819769> to track the crash internally.
Radar WebKit Bug Importer
Comment 6 2018-12-18 13:28:55 PST
<rdar://problem/46820023>
WebKit Commit Bot
Comment 7 2018-12-18 13:54:32 PST
Comment on attachment 357582 [details] Patch v1 Clearing flags on attachment: 357582 Committed r239352: <https://trac.webkit.org/changeset/239352>
WebKit Commit Bot
Comment 8 2018-12-18 13:54:34 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.