Bug 192500

Summary: [LFC] Rename formattingContext() to createFormattingContext()
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
zalan: review+
patch none

Antti Koivisto
Reported 2018-12-07 10:14:10 PST
It is not an accessor.
Attachments
patch (6.42 KB, patch)
2018-12-07 10:16 PST, Antti Koivisto 		zalan: review+
DetailsFormatted DiffDiff
patch (9.84 KB, patch)
2018-12-07 10:26 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2018-12-07 10:16:21 PST
Created attachment 356818 [details] patch
alan baradlay
Comment 2 2018-12-07 10:17:20 PST
Comment on attachment 356818 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=356818&action=review > Source/WebCore/layout/FormattingState.h:49 > + virtual std::unique_ptr<FormattingContext> createFormattingContext(const Box& formattingContextRoot) = 0; Very nice. I wonder who reviewed this originally.
Antti Koivisto
Comment 3 2018-12-07 10:22:29 PST
> Very nice. I wonder who reviewed this originally. Probably someone using a watch for reviews.
Antti Koivisto
Comment 4 2018-12-07 10:26:38 PST
Created attachment 356819 [details] patch
WebKit Commit Bot
Comment 5 2018-12-07 11:19:03 PST
The commit-queue encountered the following flaky tests while processing attachment 356819 [details]: imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_AES-CBC.https.any.worker.html bug 192505 The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2018-12-07 11:19:10 PST
The commit-queue encountered the following flaky tests while processing attachment 356819 [details]: imported/w3c/web-platform-tests/html/the-xhtml-syntax/parsing-xhtml-documents/xhtml-mathml-dtd-entity-3.htm bug 192506 (author: youennf@gmail.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2018-12-07 11:25:53 PST
Comment on attachment 356819 [details] patch Clearing flags on attachment: 356819 Committed r238961: <https://trac.webkit.org/changeset/238961>
WebKit Commit Bot
Comment 8 2018-12-07 11:25:54 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-12-07 11:26:44 PST
<rdar://problem/46559821>
Note You need to log in before you can comment on or make changes to this bug.