Bug 192465

Summary: [BFC][MarginCollapsing] Extend margin collapsing rules.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: NEW    
Severity: Normal CC: ahmad.saleem792, bfulgham, koivisto, simon.fraser, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch koivisto: review+

alan
Reported 2018-12-06 07:44:02 PST
ssia
Attachments
Patch (22.25 KB, patch)
2018-12-06 07:45 PST, alan 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2018-12-06 07:45:54 PST
Created attachment 356727 [details] Patch
Antti Koivisto
Comment 2 2018-12-06 09:39:50 PST
Comment on attachment 356727 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356727&action=review > Source/WebCore/layout/blockformatting/BlockFormattingContext.h:108 > + static bool marginTopCollapsesWithParent(const LayoutState&, const Box&); > + static bool marginTopCollapsesWithSibling(const Box&); > + static bool marginBottomCollapsesWithSibling(const Box&); > + static bool marginsCollapseThrough(const Box&); Word 'margin' in these is a bit redundant.
Ahmad Saleem
Comment 3 2022-10-09 06:04:52 PDT
It seems this r+ patch didn't landed and I checked via Webkit GitHub. @Alan - is this needed? Thanks!
Note You need to log in before you can comment on or make changes to this bug.