Bug 192431

Summary: Fix MiniBrowser's entitlements
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, ggaren, joepeck, opendarwin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Benjamin Poulain
Reported 2018-12-05 14:46:56 PST
Fix MiniBrowser's entitlements
Attachments
Patch (1.82 KB, patch)
2018-12-05 14:49 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (1.31 KB, patch)
2019-02-08 22:23 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2018-12-05 14:49:06 PST
Created attachment 356661 [details] Patch
Joseph Pecoraro
Comment 2 2019-02-08 15:14:32 PST
Comment on attachment 356661 [details] Patch r=me
Joseph Pecoraro
Comment 3 2019-02-08 15:15:02 PST
*** Bug 187494 has been marked as a duplicate of this bug. ***
Joseph Pecoraro
Comment 4 2019-02-08 15:15:18 PST
*** Bug 193159 has been marked as a duplicate of this bug. ***
WebKit Commit Bot
Comment 5 2019-02-08 22:11:53 PST
Comment on attachment 356661 [details] Patch Rejecting attachment 356661 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 356661, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=356661&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=192431&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 356661 from bug 192431. Fetching: https://bugs.webkit.org/attachment.cgi?id=356661 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Joseph Pecoraro']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/MiniBrowser/MiniBrowser.entitlements Hunk #1 FAILED at 2. 1 out of 1 hunk FAILED -- saving rejects to file Tools/MiniBrowser/MiniBrowser.entitlements.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Joseph Pecoraro']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/11088193
Benjamin Poulain
Comment 6 2019-02-08 22:23:52 PST
Created attachment 361597 [details] Patch
Benjamin Poulain
Comment 7 2019-02-08 22:24:20 PST
Thanks for the review Joe.
WebKit Commit Bot
Comment 8 2019-02-09 00:11:09 PST
Comment on attachment 361597 [details] Patch Clearing flags on attachment: 361597 Committed r241238: <https://trac.webkit.org/changeset/241238>
WebKit Commit Bot
Comment 9 2019-02-09 00:11:11 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2019-02-09 00:12:41 PST
<rdar://problem/47939735>
Note You need to log in before you can comment on or make changes to this bug.