Bug 192228

Summary: [ews-app] Ensure only one instance of BugzillaPatchFetcher is running
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: ASSIGNED    
Severity: Normal CC: aakash_jain, ap, dino, ews-watchlist, kocsen_chung, lforschler
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
dino: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews124 for ios-simulator-wk2 none

Aakash Jain
Reported 2018-11-30 09:01:12 PST
Since BugzillaPatchFetcher.fetch() can be invoked asynchronously, we should ensure only one instance of BugzillaPatchFetcher is running at a time.
Attachments
Proposed patch (2.23 KB, patch)
2018-11-30 09:14 PST, Aakash Jain 		dino: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (2.45 MB, application/zip)
2018-12-02 13:11 PST, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2018-11-30 09:14:16 PST
Created attachment 356184 [details] Proposed patch
EWS Watchlist
Comment 2 2018-12-02 13:11:16 PST
Comment on attachment 356184 [details] Proposed patch Attachment 356184 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10241410 New failing tests: imported/w3c/web-platform-tests/webrtc/simplecall-no-ssrcs.https.html
EWS Watchlist
Comment 3 2018-12-02 13:11:17 PST
Created attachment 356345 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Kocsen Chung
Comment 4 2018-12-03 16:29:16 PST
Comment on attachment 356184 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=356184&action=review > Tools/BuildSlaveSupport/ews-app/ews/fetcher.py:33 > + isRunning = False nit: can we use underscore separated variables for PEP8 adherence? `is_running`
Note You need to log in before you can comment on or make changes to this bug.