Bug 192222

Summary: [WebGPU] Add scaffolding to parse WHLSL shaders
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED WONTFIX    
Severity: Normal CC: dino, ews-watchlist, fpizlo, glenn, jonlee, justin_fan, rmorisset, simon.fraser, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mmaxfield: review-

Myles C. Maxfield
Reported 2018-11-29 23:03:58 PST
[WebGPU] Add scaffolding to parse WHLSL shaders
Attachments
Patch (19.33 MB, patch)
2018-11-29 23:13 PST, Myles C. Maxfield 		mmaxfield: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2018-11-29 23:13:08 PST
Created attachment 356148 [details] Patch
Myles C. Maxfield
Comment 2 2018-11-29 23:16:52 PST
This doesn't build ANTLR from source; instead, it just checks in the precompiled runtime and parser generator tool. We can use them out-of-the-box, so I don't think it's necessary to waste everyone's time building them.
Dean Jackson
Comment 3 2018-11-30 09:40:54 PST
I can't seem to get the "Review Patch" page to work with such a big patch, so I'll comment here. - do we have permission from legal to include this 3rd party tool? - would it be better to start with a result generated offline, before including the tool?
Myles C. Maxfield
Comment 4 2018-11-30 12:00:10 PST
(In reply to Dean Jackson from comment #3) > I can't seem to get the "Review Patch" page to work with such a big patch, > so I'll comment here. > > - do we have permission from legal to include this 3rd party tool? Do we need to? It's using the BSD license. > - would it be better to start with a result generated offline, before > including the tool? The tool is written in Java and the bots don't have Java installed so we're either going to have to install Java on the bots and all the WebKit dev's machines or do what you propose. (Or not use ANTLR)
Note You need to log in before you can comment on or make changes to this bug.