Bug 191959

Summary:

[Clang][WebKitLegacy][Win] MarshallingHelpers.h(65,47): warning: extra qualification on member 'windowsEpochAbsoluteTime' [-Wmicrosoft-extra-qualification]

Product:

WebKit

Reporter:

Fujii Hironori <fujii>

Component:

WebKit Misc.

Assignee:

Fujii Hironori <fujii>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bfulgham, ews-watchlist, pvollan, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

171618

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none

Fujii Hironori

Reported 2018-11-25 21:11:27 PST

[Clang][WebKitLegacy][Win] MarshallingHelpers.h(65,47): warning: extra qualification on member 'windowsEpochAbsoluteTime' [-Wmicrosoft-extra-qualification] clang-cl reports a following compilation warning: > [5870/6237] Building CXX object Source\WebKitLegacy\CMakeFiles\WebKitLegacy.dir\win\WebView.cpp.obj > In file included from ..\..\Source\WebKitLegacy\win\WebView.cpp:34: > ..\..\Source\WebKitLegacy\win/MarshallingHelpers.h(65,47): warning: extra qualification on member 'windowsEpochAbsoluteTime' [-Wmicrosoft-extra-qualification] > static CFAbsoluteTime MarshallingHelpers::windowsEpochAbsoluteTime(); > ~~~~~~~~~~~~~~~~~~~~^ This code has been introduce in following commits. https://trac.webkit.org/changeset/23462 https://trac.webkit.org/changeset/22102

Attachments
Patch (1.39 KB, patch) 2018-11-25 21:18 PST, Fujii Hironori	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.60 MB, application/zip) 2018-11-26 01:47 PST, EWS Watchlist	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Fujii Hironori

Comment 1 2018-11-25 21:18:53 PST

Created attachment 355619 [details] Patch

EWS Watchlist

Comment 2 2018-11-26 01:47:39 PST Comment hidden (obsolete)

Comment on attachment 355619 [details] Patch Attachment 355619 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10151742 New failing tests: media/no-fullscreen-when-hidden.html

EWS Watchlist

Comment 3 2018-11-26 01:47:40 PST Comment hidden (obsolete)

Created attachment 355627 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Fujii Hironori

Comment 4 2018-11-26 18:09:55 PST

Comment on attachment 355619 [details] Patch Clearing flags on attachment: 355619 Committed r238542: <https://trac.webkit.org/changeset/238542>

Fujii Hironori

Comment 5 2018-11-26 18:09:58 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 6 2018-11-26 18:10:56 PST

<rdar://problem/46263741>

Note You need to log in before you can comment on or make changes to this bug.