Bug 191332

Summary: Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, jeremyj-wk, slewis, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

Jer Noble
Reported 2018-11-06 14:42:13 PST
Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
Attachments
Patch (2.23 KB, patch)
2018-11-06 14:44 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (2.35 KB, patch)
2018-11-06 15:01 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (2.41 KB, patch)
2018-11-06 15:14 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.64 KB, patch)
2019-02-20 15:02 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.79 KB, patch)
2019-02-20 15:06 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2018-11-06 14:44:09 PST
Created attachment 354011 [details] Patch
Jer Noble
Comment 2 2018-11-06 15:01:10 PST
Created attachment 354013 [details] Patch
Jer Noble
Comment 3 2018-11-06 15:14:43 PST
Created attachment 354016 [details] Patch
Dean Jackson
Comment 4 2018-11-12 10:21:30 PST
Comment on attachment 354016 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354016&action=review > Tools/Scripts/git-is-in-range:3 > +USAGE="<commit range> <commit> [commit...]" Another request was given a set of ranges, find the overlapping range. Maybe you should explain what a <commit range> looks like? I assume it is hash1..hash2?
Jer Noble
Comment 5 2019-02-20 15:02:32 PST
Created attachment 362549 [details] Patch for landing
Jer Noble
Comment 6 2019-02-20 15:06:07 PST
Created attachment 362550 [details] Patch for landing
Jer Noble
Comment 7 2019-02-20 15:08:58 PST
(In reply to Dean Jackson from comment #4) > Comment on attachment 354016 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=354016&action=review > > > Tools/Scripts/git-is-in-range:3 > > +USAGE="<commit range> <commit> [commit...]" > > Another request was given a set of ranges, find the overlapping range. Okay. Another request I've heard is: given two commits, figure out which is older (and presumably, whether one is reachable from the other). > Maybe you should explain what a <commit range> looks like? I assume it is > hash1..hash2? Good idea. Added a LONG_USAGE.
WebKit Commit Bot
Comment 8 2019-02-20 15:25:29 PST
Comment on attachment 362550 [details] Patch for landing Clearing flags on attachment: 362550 Committed r241843: <https://trac.webkit.org/changeset/241843>
WebKit Commit Bot
Comment 9 2019-02-20 15:25:30 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2019-02-20 15:26:49 PST
<rdar://problem/48254663>
Note You need to log in before you can comment on or make changes to this bug.