Bug 191330

Summary: IntersectionObserverEntry doesn't keep JS wrappers of rects alive
Product: WebKit Reporter: Ali Juma <ajuma>
Component: Layout and RenderingAssignee: Ali Juma <ajuma>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, kangil.han, kondapallykalyan, rniwa, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 159475    
Attachments:
Description Flags
Patch none

Ali Juma
Reported 2018-11-06 14:22:32 PST
Following up on rniwa's review comment in bug 190235, we need to make sure that wrappers of the DOMRectReadOnly objects in IntersectionObserverEntry get visited during GC.
Attachments
Patch (7.40 KB, patch)
2018-11-07 06:46 PST, Ali Juma 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ali Juma
Comment 1 2018-11-07 06:46:43 PST
Created attachment 354087 [details] Patch
Chris Dumez
Comment 2 2018-11-07 09:43:19 PST
Comment on attachment 354087 [details] Patch r=me
WebKit Commit Bot
Comment 3 2018-11-07 10:30:38 PST
Comment on attachment 354087 [details] Patch Clearing flags on attachment: 354087 Committed r237929: <https://trac.webkit.org/changeset/237929>
WebKit Commit Bot
Comment 4 2018-11-07 10:30:40 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-11-07 10:32:30 PST
<rdar://problem/45879997>
Note You need to log in before you can comment on or make changes to this bug.