Bug 190899

Summary: REGRESSION (r237255): Text selection is broken in form fields
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Ali Juma <ajuma>
Status: RESOLVED FIXED    
Severity: Normal CC: ajuma, bfulgham, commit-queue, dbates, ews-watchlist, rniwa, simon.fraser, webkit-bug-importer, wenson_hsieh, zalan
Priority: P2 Keywords: InRadar, Regression
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 189833    
Bug Blocks:    
Attachments:
Description Flags
Example of breakage with overflow:hidden
none
Patch
none
Archive of layout-test-results from ews206 for win-future
none
Patch none

Simon Fraser (smfr)
Reported 2018-10-25 02:25:21 PDT
When I move my cursor to select a chunk of text, the text I have selected is not highlighted or only partially highlighted.
Attachments
Example of breakage with overflow:hidden (248 bytes, text/html)
2018-10-25 11:31 PDT, Daniel Bates 		no flags
Details
Patch (3.78 KB, patch)
2018-10-25 12:54 PDT, Ali Juma 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews206 for win-future (12.68 MB, application/zip)
2018-10-25 14:46 PDT, EWS Watchlist 		no flags
Details
Patch (4.28 KB, patch)
2018-10-25 15:03 PDT, Ali Juma 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2018-10-25 02:26:26 PDT
<rdar://problem/45456392>
Daniel Bates
Comment 2 2018-10-25 11:30:16 PDT
*** Bug 190905 has been marked as a duplicate of this bug. ***
Daniel Bates
Comment 3 2018-10-25 11:31:57 PDT
Created attachment 353096 [details] Example of breakage with overflow:hidden For convenience, attached the example page from bug #190905.
Ali Juma
Comment 4 2018-10-25 12:52:43 PDT
*** Bug 190905 has been marked as a duplicate of this bug. ***
Ali Juma
Comment 5 2018-10-25 12:54:38 PDT
Created attachment 353101 [details] Patch
EWS Watchlist
Comment 6 2018-10-25 14:46:46 PDT
Comment on attachment 353101 [details] Patch Attachment 353101 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/9729658 New failing tests: fast/repaint/text-selection-overflow-hidden.html
EWS Watchlist
Comment 7 2018-10-25 14:46:58 PDT
Created attachment 353111 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Ali Juma
Comment 8 2018-10-25 15:03:32 PDT
Created attachment 353112 [details] Patch Add baseline for Windows
WebKit Commit Bot
Comment 9 2018-10-26 06:16:14 PDT
Comment on attachment 353112 [details] Patch Clearing flags on attachment: 353112 Committed r237449: <https://trac.webkit.org/changeset/237449>
WebKit Commit Bot
Comment 10 2018-10-26 06:16:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.