Bug 189640

Summary: Support two color hints per color stop for all gradients
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: bdakin, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch simon.fraser: review+

Megan Gardner
Reported 2018-09-14 17:24:21 PDT
Support two color hints per color stop for angle based gradients
Attachments
Patch (6.09 KB, patch)
2018-09-14 17:26 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (6.12 KB, patch)
2018-09-14 17:48 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (19.33 KB, patch)
2018-09-17 16:03 PDT, Megan Gardner 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2018-09-14 17:26:27 PDT
Created attachment 349835 [details] Patch
Megan Gardner
Comment 2 2018-09-14 17:26:29 PDT
<rdar://problem/44158152>
Megan Gardner
Comment 3 2018-09-14 17:48:41 PDT
Created attachment 349841 [details] Patch
Simon Fraser (smfr)
Comment 4 2018-09-14 17:53:08 PDT
Comment on attachment 349841 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349841&action=review > Source/WebCore/ChangeLog:10 > + The CSS spec for conic gradients allows for each color stop to have two angles to be used for hints. > + This makes pie chart and checkerboard gradients much simpler to write. It also does for linear and radial gradients: see https://www.w3.org/TR/css-images-4/#color-stop-syntax so we should fix their parsing too.
Megan Gardner
Comment 5 2018-09-17 16:03:40 PDT
Created attachment 349964 [details] Patch
Simon Fraser (smfr)
Comment 6 2018-09-17 16:25:39 PDT
Comment on attachment 349964 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349964&action=review > Source/WebCore/ChangeLog:10 > + The CSS spec for conic gradients allows for each color stop to have two angles to be used for hints. > + This makes pie chart and checkerboard gradients much simpler to write. This text is out of date now.
Fredrik Söderquist
Comment 7 2018-09-18 07:33:21 PDT
Should bug# 186154 be duped into this?
Simon Fraser (smfr)
Comment 8 2018-09-18 11:09:15 PDT
Yes! Megan, perhaps change the Changelog and commit message to reference https://bugs.webkit.org/show_bug.cgi?id=186154 and dup this to that.
Megan Gardner
Comment 9 2018-09-18 13:58:08 PDT
*** This bug has been marked as a duplicate of bug 186154 ***
Note You need to log in before you can comment on or make changes to this bug.