Bug 189637

Summary: The BytecodeGenerator should not waste time calling emitDebugHook() when the debugger is off.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: ASSIGNED    
Severity: Normal CC: ews-watchlist, joepeck, keith_miller, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
ews-watchlist: commit-queue-
x86_64 benchmark results.
none
Archive of layout-test-results from ews117 for mac-sierra none

Mark Lam
Reported 2018-09-14 16:48:29 PDT
emitDebugHook() will always check BytecodeGenerator::m_shouldEmitDebugHooks and return early anyway. We can cut this code path off earlier, and save a bunch of calls.
Attachments
proposed patch. (30.04 KB, patch)
2018-09-17 13:11 PDT, Mark Lam 		ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
x86_64 benchmark results. (96.59 KB, text/plain)
2018-09-17 13:17 PDT, Mark Lam 		no flags
Details
Archive of layout-test-results from ews117 for mac-sierra (3.64 MB, application/zip)
2018-09-17 14:57 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-09-14 16:48:59 PDT
<rdar://problem/44473828>
Mark Lam
Comment 2 2018-09-17 13:11:31 PDT
Created attachment 349926 [details] proposed patch. Perf appears to be neutral. Let's get some EWS testing.
Mark Lam
Comment 3 2018-09-17 13:17:58 PDT
Created attachment 349929 [details] x86_64 benchmark results.
EWS Watchlist
Comment 4 2018-09-17 14:57:11 PDT
Comment on attachment 349926 [details] proposed patch. Attachment 349926 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9247414 Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 5 2018-09-17 14:57:13 PDT
Created attachment 349945 [details] Archive of layout-test-results from ews117 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6
Note You need to log in before you can comment on or make changes to this bug.