Bug 189631

Summary: Refactoring related to Safe Browsing
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jlewis3, realdawei, ryanhaddad, thorton, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2018-09-14 14:15:02 PDT
Refactoring related to Safe Browsing
Attachments
Patch (17.49 KB, patch)
2018-09-14 14:20 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (17.57 KB, patch)
2018-09-14 14:29 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (17.51 KB, patch)
2018-09-17 09:32 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2018-09-14 14:20:24 PDT
Created attachment 349803 [details] Patch
Alex Christensen
Comment 2 2018-09-14 14:29:37 PDT
Created attachment 349807 [details] Patch
WebKit Commit Bot
Comment 3 2018-09-14 15:09:39 PDT
Comment on attachment 349807 [details] Patch Clearing flags on attachment: 349807 Committed r236020: <https://trac.webkit.org/changeset/236020>
WebKit Commit Bot
Comment 4 2018-09-14 15:09:41 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-09-14 15:10:23 PDT
<rdar://problem/44470854>
Dawei Fenton (:realdawei)
Comment 6 2018-09-14 16:10:23 PDT
(In reply to WebKit Commit Bot from comment #3) > Comment on attachment 349807 [details] > Patch > > Clearing flags on attachment: 349807 > > Committed r236020: <https://trac.webkit.org/changeset/236020> Seeing an API test failure on High Sierra WK1 after this revision: sample output: https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK1%20%28Tests%29/builds/7991/steps/run-api-tests/logs/stdio TestWebKitAPI.WKNavigation.NavigationActionHasNavigation /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:236 Value of: !!navigationAction._mainFrameNavigation Actual: false Expected: true /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:237 Expected equality of these values: navigationAction._mainFrameNavigation Which is: NULL navigation Which is: 0x7f8421c36260
Matt Lewis
Comment 7 2018-09-14 18:20:34 PDT
Reverted r236020 for reason: This caused an api failure on High Sierra Committed r236030: <https://trac.webkit.org/changeset/236030>
Alex Christensen
Comment 8 2018-09-17 09:32:17 PDT
Created attachment 349892 [details] Patch
WebKit Commit Bot
Comment 9 2018-09-17 10:09:54 PDT
Comment on attachment 349892 [details] Patch Clearing flags on attachment: 349892 Committed r236067: <https://trac.webkit.org/changeset/236067>
WebKit Commit Bot
Comment 10 2018-09-17 10:09:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.