Bug 189627

Summary: XMLHttpRequest::createResponseBlob() should create a Blob with type for empty response
Product: WebKit Reporter: Rob Buis <rbuis>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ap: review+, commit-queue: commit-queue-

Rob Buis
Reported 2018-09-14 13:02:29 PDT
Right now we return an empty Blob without type when the response is empty, but it should include the type always: https://xhr.spec.whatwg.org/#blob-response
Attachments
Patch (3.47 KB, patch)
2018-09-14 13:06 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (5.43 KB, patch)
2018-09-14 13:51 PDT, Rob Buis 		ap: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2018-09-14 13:06:32 PDT
Created attachment 349791 [details] Patch
Rob Buis
Comment 2 2018-09-14 13:51:59 PDT
Created attachment 349800 [details] Patch
WebKit Commit Bot
Comment 3 2018-09-18 09:06:46 PDT
Comment on attachment 349800 [details] Patch Rejecting attachment 349800 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 349800, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=349800&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=189627&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 349800 from bug 189627. Fetching: https://bugs.webkit.org/attachment.cgi?id=349800 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Alexey Proskuryakov']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 7 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/xml/XMLHttpRequest.cpp Hunk #1 FAILED at 220. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/xml/XMLHttpRequest.cpp.rej patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/imported/w3c/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/fast/files/xhr-response-blob-expected.txt Hunk #1 FAILED at 16. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/fast/files/xhr-response-blob-expected.txt.rej patching file LayoutTests/fast/files/xhr-response-blob.html Hunk #1 FAILED at 34. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/fast/files/xhr-response-blob.html.rej patching file LayoutTests/imported/w3c/web-platform-tests/xhr/overridemimetype-blob-expected.txt Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/imported/w3c/web-platform-tests/xhr/overridemimetype-blob-expected.txt.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Alexey Proskuryakov']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/9257282
Rob Buis
Comment 4 2018-09-18 09:08:22 PDT
Landed in https://trac.webkit.org/changeset/236031/webkit.
Chris Dumez
Comment 5 2018-09-18 09:08:36 PDT
Looks like Rob already committed this in http://trac.webkit.org/r236031 but forgot to update the bug.
Radar WebKit Bug Importer
Comment 6 2018-09-18 09:09:24 PDT
<rdar://problem/44562384>
Rob Buis
Comment 7 2018-09-18 09:10:45 PDT
(In reply to Chris Dumez from comment #5) > Looks like Rob already committed this in http://trac.webkit.org/r236031 but > forgot to update the bug. Yep, sorry! I have to get used to this workflow again.
Note You need to log in before you can comment on or make changes to this bug.