Bug 189588

Summary: [WPE][GTK] Docs for WebKitWebView::load-failed do not tell which kind of errors are reported
Product: WebKit Reporter: Adrian Perez <aperez>
Component: WebKit APIAssignee: Adrian Perez <aperez>
Status: NEW    
Severity: Normal CC: berto, cgarcia, ews-watchlist, gustavo, mcatanzaro
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mcatanzaro: review-, mcatanzaro: commit-queue-

Adrian Perez
Reported 2018-09-13 09:46:59 PDT
As stated in the subject, the API documentation for the “WebKitWebView::load-failed” signal fail to mention which error domains may be set in the ”GError” instance passed to the signal handlers. Making people who want to use WebKit (GTK+/WPE) to dive into WebKit's source code to find out which kind of errors to handle is horrible, let's fix this.
Attachments
Patch (1.64 KB, patch)
2018-09-13 10:10 PDT, Adrian Perez 		mcatanzaro: review-
mcatanzaro: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2018-09-13 10:10:44 PDT
Created attachment 349676 [details] Patch
EWS Watchlist
Comment 2 2018-09-13 10:13:14 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Michael Catanzaro
Comment 3 2018-09-13 11:56:03 PDT
Comment on attachment 349676 [details] Patch I'm pretty sure this is not exhaustive: * https://gitlab.gnome.org/GNOME/epiphany/issues/533 is caused by G_IO_ERROR, so we know that, at least, is also possible * Epiphany also checks for WEBKIT_POLICY_ERROR, so presumably that is possible too I'm quite nervous about documenting anything here unless we are really certain about the possible error domains. E.g. Epiphany doesn't expect SOUP_HTTP_ERROR or G_IO_ERROR. So we need to be more confident about what can really happen here.
Note You need to log in before you can comment on or make changes to this bug.