Bug 189584

Summary: [GStreamer] WebAudio idle/silence playback improvements
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: PlatformAssignee: Philippe Normand <pnormand>
Status: RESOLVED INVALID    
Severity: Normal CC: calvaris, eocanha, ews-watchlist, philn
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-watchlist: commit-queue-
Archive of layout-test-results from ews124 for ios-simulator-wk2 none

Attachments
Patch (4.16 KB, patch)
2018-09-13 07:00 PDT, Philippe Normand 		ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (2.40 MB, application/zip)
2018-09-13 08:57 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2018-09-13 07:00:43 PDT
Created attachment 349662 [details] Patch
EWS Watchlist
Comment 2 2018-09-13 08:57:32 PDT
Comment on attachment 349662 [details] Patch Attachment 349662 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9203122 New failing tests: fast/animation/css-animation-resuming-when-visible-with-style-change2.html
EWS Watchlist
Comment 3 2018-09-13 08:57:34 PDT
Created attachment 349674 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Xabier Rodríguez Calvar
Comment 4 2018-09-13 09:37:34 PDT
Comment on attachment 349662 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349662&action=review It would be interesting to be a bit more verbose in the ChangLog > Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:385 > + Remove extra line... > Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:396 > + g_usleep(1000); I think we can use WTF::sleep, can't we?
Philippe Normand
Comment 5 2018-09-19 08:09:15 PDT
Comment on attachment 349662 [details] Patch Well, actually :) After checking this patch more carefully, I wonder if we can perhaps have something different than a workaround. I would like to experiment with a rewrite of this src element, make it inherit from audiosrc. An audio converter would internally handle the conversion to interleaved layout. I started a patch...
Philippe Normand
Comment 6 2024-05-01 08:05:36 PDT
(In reply to Philippe Normand from comment #5) > Comment on attachment 349662 [details] > Patch > > Well, actually :) > After checking this patch more carefully, I wonder if we can perhaps have > something different than a workaround. > > I would like to experiment with a rewrite of this src element, make it > inherit from audiosrc. An audio converter would internally handle the > conversion to interleaved layout. > > I started a patch... Rewriting this wouldn't be trivial due to the threading requirements of AudioWorklet... This patch no longer applies and it seems downstream is not using it anymore. Closing.
Note You need to log in before you can comment on or make changes to this bug.