Bug 189514

Summary: [Cocoa] Dictionary hangs when searching
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: TextAssignee: Myles C. Maxfield <mmaxfield>
Status: NEW    
Severity: Normal CC: dino, ews-watchlist, jonlee, mmaxfield, rniwa, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
simon.fraser: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews107 for mac-sierra-wk2
none
Archive of layout-test-results from ews114 for mac-sierra
none
Archive of layout-test-results from ews102 for mac-sierra none

Myles C. Maxfield
Reported 2018-09-11 12:14:05 PDT
[Cocoa] Dictionary hangs when searching
Attachments
Patch (9.32 KB, patch)
2018-09-11 12:15 PDT, Myles C. Maxfield 		simon.fraser: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.45 MB, application/zip)
2018-09-11 13:19 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews114 for mac-sierra (3.46 MB, application/zip)
2018-09-11 13:34 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews102 for mac-sierra (2.62 MB, application/zip)
2018-09-11 13:43 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2018-09-11 12:15:32 PDT
Created attachment 349420 [details] Patch
Myles C. Maxfield
Comment 2 2018-09-11 12:15:35 PDT
<rdar://problem/40027979>
Simon Fraser (smfr)
Comment 3 2018-09-11 13:00:17 PDT
Comment on attachment 349420 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349420&action=review > Source/WebCore/page/cocoa/SettingsBaseCocoa.mm:59 > RetainPtr<CFNumberRef> yes = adoptCF(CFNumberCreate(kCFAllocatorDefault, kCFNumberIntType, &one)); 'yes' is now unused.
EWS Watchlist
Comment 4 2018-09-11 13:19:03 PDT
Comment on attachment 349420 [details] Patch Attachment 349420 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9176203 New failing tests: fast/css/font-weight-1.html css2.1/20110323/overflow-applies-to-009.htm fast/ruby/ruby-text-before-child-split.html fast/ruby/ruby-base-merge-block-children-crash.html fast/css3-text/font-synthesis.html fast/text/fake-italic.html fast/text/cg-fallback-bolding.html
EWS Watchlist
Comment 5 2018-09-11 13:19:05 PDT
Created attachment 349433 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 6 2018-09-11 13:34:18 PDT
Comment on attachment 349420 [details] Patch Attachment 349420 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9176200 New failing tests: fast/css/font-weight-1.html css2.1/20110323/overflow-applies-to-009.htm fast/ruby/ruby-text-before-child-split.html fast/ruby/ruby-base-merge-block-children-crash.html fast/css3-text/font-synthesis.html fast/text/fake-italic.html fast/text/cg-fallback-bolding.html
EWS Watchlist
Comment 7 2018-09-11 13:34:20 PDT
Created attachment 349438 [details] Archive of layout-test-results from ews114 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 8 2018-09-11 13:42:58 PDT
Comment on attachment 349420 [details] Patch Attachment 349420 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9176801 New failing tests: fast/css/font-weight-1.html css2.1/20110323/overflow-applies-to-009.htm fast/ruby/ruby-text-before-child-split.html fast/ruby/ruby-base-merge-block-children-crash.html fast/css3-text/font-synthesis.html fast/text/fake-italic.html fast/text/cg-fallback-bolding.html
EWS Watchlist
Comment 9 2018-09-11 13:43:00 PDT
Created attachment 349443 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Myles C. Maxfield
Comment 10 2018-09-11 14:08:11 PDT
This causes test failures??? 😧
Note You need to log in before you can comment on or make changes to this bug.