| Summary: | Tests checking document GC in case of ActiveDOMObjects are flaky | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
| Component: | Page Loading | Assignee: | youenn fablet <youennf> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, beidson, cdumez, commit-queue, eric.carlson, graouts, ryanhaddad, simon.fraser, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=189704 https://bugs.webkit.org/show_bug.cgi?id=190851 |
||||||||
| Attachments: |
|
||||||||
|
Description
youenn fablet
2018-09-07 10:13:31 PDT
See https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2FIndexedDB%2Fcollect-IDB-objects.https.html and https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fmedia%2Fclearkey%2Fcollect-webkit-media-session.html. Created attachment 349155 [details]
Patch
Comment on attachment 349155 [details] Patch Clearing flags on attachment: 349155 Committed r235819: <https://trac.webkit.org/changeset/235819> All reviewed patches have been landed. Closing bug. http/tests/media/clearkey/collect-webkit-media-session.html failed here, and appears to remain quite flaky: https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK1%20(Tests)/r235847%20(7874)/results.html http/tests/IndexedDB/collect-IDB-objects.https.html failed here: https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r235833%20(6651)/results.html Reopening because these tests are still flaky. This means we have no effective leak tracking :( Marked http/tests/media/clearkey/collect-webkit-media-session.html as flaky in https://trac.webkit.org/r236340 because it is frequently popping up on the bots. Youenn, would you take a look at this. (In reply to Ryan Haddad from comment #9) > Marked http/tests/media/clearkey/collect-webkit-media-session.html as flaky > in https://trac.webkit.org/r236340 because it is frequently popping up on > the bots. > > Youenn, would you take a look at this. Looked at it a bit. Apparently, the document is not always GCed, but it has no pending activity so something else is going on. I'll try digging further with the GC heap debugger. Created attachment 350464 [details]
Patch
Comment on attachment 350464 [details] Patch Clearing flags on attachment: 350464 Committed r236389: <https://trac.webkit.org/changeset/236389> All reviewed patches have been landed. Closing bug. |