Bug 189404

Summary: Also copy JSC when running benchmarks on remote machine
Product: WebKit Reporter: Dominik Inführ <dominik.infuehr>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: achristensen, angelos, bfulgham, fpizlo, saam, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Dominik Inführ 2018-09-07 06:07:33 PDT 
Also copy JSC when running benchmarks on remote machine
Comment 1 Dominik Inführ 2018-09-07 06:08:06 PDT 
Created attachment 349141 [details]
Patch
Comment 2 Dominik Inführ 2018-09-07 06:10:00 PDT 
Created attachment 349142 [details]
Patch
Comment 3 Dominik Inführ 2018-09-07 06:15:27 PDT 
When running benchmarks with `$WEBKIT/Tools/Scripts/run-jsc-benchmarks name:$BUILD_DIR/Release/bin/jsc --remote user@host`, JSC doesn't get copied onto the remote machine, only $BUILD_DIR/Release/lib is copied.
Comment 4 Dominik Inführ 2018-12-17 04:37:55 PST 
Created attachment 357435 [details]
Patch
Comment 5 Dominik Inführ 2018-12-17 06:44:14 PST 
I've updated the change.
Comment 6 Alex Christensen 2021-11-01 12:43:50 PDT 
Comment on attachment 357435 [details]
Patch

This has been requesting review for more than one year.  If this is still needed, please rebase and re-request review.
Comment 7 Angelos Oikonomopoulos 2022-12-23 04:29:42 PST 
(In reply to Alex Christensen from comment #6)
> Comment on attachment 357435 [details]
> Patch
> 
> This has been requesting review for more than one year.  If this is still
> needed, please rebase and re-request review.

AFAICT this has been fixed in https://bugs.webkit.org/show_bug.cgi?id=227579.
Comment 8 Angelos Oikonomopoulos 2022-12-23 04:30:19 PST 

*** This bug has been marked as a duplicate of bug 227579 ***