| Summary: | [WebAssembly] Optimize JS to Wasm call by using pointer of Signature as SignatureIndex | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||||||||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
Yusuke Suzuki
2018-09-07 02:42:45 PDT
Created attachment 349131 [details]
Patch
Created attachment 349134 [details]
Patch
Created attachment 349136 [details]
Patch
Created attachment 349137 [details]
Patch
Created attachment 349138 [details]
Patch
Created attachment 349139 [details]
Patch
Created attachment 349140 [details]
Patch
Created attachment 349143 [details]
Patch
Comment on attachment 349143 [details]
Patch
r=me. I think you should remove Signature::firstValidIndex since it is no longer used.
(In reply to Mark Lam from comment #9) > Comment on attachment 349143 [details] > Patch > > r=me. I think you should remove Signature::firstValidIndex since it is no > longer used. Right! Thanks. Fixed. Committed r235786: <https://trac.webkit.org/changeset/235786> Comment on attachment 349143 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349143&action=review Nice change. The only thing that's weird to me is that we're still calling it an index. We should revise the name since the old name indicated an implementation style. But we're no longer using it as an index. Maybe we could call it something like UniqueSignature. > Source/JavaScriptCore/ChangeLog:20 > + This change significantly optimizes JS to wasm calls (1e7 times) from 600ms to 320ms. Our wasm entry is so slow :( |