| Summary: | Cleanup: Remove extraneous "using namespace" and scope WebCore::LogThreading | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||
| Component: | WebCore Misc. | Assignee: | Daniel Bates <dbates> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aestes, ddkilzer, simon.fraser, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 189389 | ||||||
| Attachments: |
|
||||||
Created attachment 349088 [details]
Patch
Comment on attachment 349088 [details] Patch Clearing flags on attachment: 349088 Committed r235816: <https://trac.webkit.org/changeset/235816> All reviewed patches have been landed. Closing bug. |
Today I made some changes in my local working copy that affected the grouping of unified source files such that I got my build failed with the following errors: [[ In file included from /Volumes/.../DerivedSources/WebCore/unified-sources/UnifiedSource29-mm.mm:1: platform/ios/wak/WKGraphics.mm:34:17: error: expected namespace name using namespace WebCore; ^ In file included from /Volumes/.../DerivedSources/WebCore/unified-sources/UnifiedSource29-mm.mm:3: platform/ios/wak/WebCoreThread.mm:868:20: error: no member named 'Threading' in namespace 'WebCore'; did you mean 'LogThreading'? using WebCore::Threading; ~~~~~~~~~^~~~~~~~~ LogThreading In file included from /Volumes/.../DerivedSources/WebCore/unified-sources/UnifiedSource29-mm.mm:3: In file included from platform/ios/wak/WebCoreThread.mm:33: /Volumes/Data/WebKitDev/Safari/OpenSource/Source/WebCore/platform/Logging.h:109:22: note: 'LogThreading' declared here WEBCORE_LOG_CHANNELS(DECLARE_LOG_CHANNEL) ^ 2 errors generated. ]]