| Summary: | Web Inspector: Dark Mode : Sidebar filter input text color wrong color when focus lost | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jamal Nasser <jamaln> | ||||||||
| Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED WONTFIX | ||||||||||
| Severity: | Normal | CC: | bburg, hi, inspector-bugzilla-changes, jamaln, joepeck | ||||||||
| Priority: | P2 | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 349073 [details]
Screenshot with patch
Created attachment 349077 [details]
Patch
I'm not seeing the issue on my machine. Are you up to date in your repo? That's odd. I just checked on revision: 235912 and the bug is still there for me. It might be because I'm forcing Dark Mode in MediaQueryEvaluator.cpp and not actually running Mojave? (In reply to Jamal Nasser from comment #4) > That's odd. I just checked on revision: 235912 and the bug is still there > for me. > It might be because I'm forcing Dark Mode in MediaQueryEvaluator.cpp and not > actually running Mojave? Form controls need system support added in Mojave to render in Dark Mode. If you are modifying WK code or running an earlier version of macOS, there are no guarantees about what will happen in dark mode code paths. Ah, thanks for the clarification Comment on attachment 349077 [details]
Patch
Clearing r? given this bug is closed.
|
Created attachment 349071 [details] Screenshot without patch The text color switches to black when focus is lost from the search fields in the sidebar