Bug 189369

Summary:

WebPage::close should clear UserMediaPermissionRequestManager

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

WebRTC

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Updated patch	none

Description Eric Carlson 2018-09-06 14:17:38 PDT

UserMediaPermissionRequestManager should not remove ActivityStateChangeObserver in destructor

Comment 1 Radar WebKit Bug Importer 2018-09-06 14:18:05 PDT

<rdar://problem/44196724>

Comment 2 Eric Carlson 2018-09-06 14:25:07 PDT

Created attachment 349072 [details]
Patch

Comment 3 youenn fablet 2018-09-06 14:44:40 PDT

Comment on attachment 349072 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349072&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:710
> +#endif

I believe this cleanup call might be too late.
How about doing it in WebPage::close() instead since it is the place where m_page is gone?
If done there, setting m_userMediaPermissionRequestManager to nullptr in WebPage::close() might be good enough.

Comment 4 Eric Carlson 2018-09-11 10:26:26 PDT

Created attachment 349406 [details]
Updated patch

Comment 5 WebKit Commit Bot 2018-09-11 16:17:30 PDT

Comment on attachment 349406 [details]
Updated patch

Clearing flags on attachment: 349406

Committed r235918: <https://trac.webkit.org/changeset/235918>

Comment 6 WebKit Commit Bot 2018-09-11 16:17:32 PDT

All reviewed patches have been landed.  Closing bug.